ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-13 17:22:15 -05:00
Code Issues Packages Projects Releases Wiki Activity

Use vertical tabs in server and database properties (#24521)

Browse Source 
* use vertical tabs

* remove always show tabs option

* remove extra comma
This commit is contained in:
Barbara Valdez
2023-10-03 13:15:50 -07:00
committed by GitHub
parent 5ed263ecd2
commit c641865891
2 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
extensions/mssql/src/objectManagement/ui/databaseDialog.ts
View File

@@ -18,6 +18,7 @@ import * as vscode from 'vscode';
const MAXDOP_Max_Limit = 32767; const MAXDOP_Max_Limit = 32767;
const PAUSED_RESUMABLE_INDEX_Max_Limit = 71582; const PAUSED_RESUMABLE_INDEX_Max_Limit = 71582;
const DscTableRowLength = 15; const DscTableRowLength = 15;
const Dialog_Width = '750px';
export class DatabaseDialog extends ObjectManagementDialogBase<Database, DatabaseViewInfo> { export class DatabaseDialog extends ObjectManagementDialogBase<Database, DatabaseViewInfo> {
// Database Properties tabs // Database Properties tabs
@@ -122,6 +123,7 @@ export class DatabaseDialog extends ObjectManagementDialogBase<Database, Databas
constructor(objectManagementService: IObjectManagementService, options: ObjectManagementDialogOptions) { constructor(objectManagementService: IObjectManagementService, options: ObjectManagementDialogOptions) {
options.width = Dialog_Width;
super(objectManagementService, options); super(objectManagementService, options);
} }
@@ -267,6 +269,9 @@ export class DatabaseDialog extends ObjectManagementDialogBase<Database, Databas
const propertiesTabGroup = { title: '', tabs: tabs }; const propertiesTabGroup = { title: '', tabs: tabs };
const propertiesTabbedPannel = this.modelView.modelBuilder.tabbedPanel() const propertiesTabbedPannel = this.modelView.modelBuilder.tabbedPanel()
.withTabs([propertiesTabGroup]) .withTabs([propertiesTabGroup])
.withLayout({
orientation: azdata.TabOrientation.Vertical
})
.withProps({ .withProps({
CSSStyles: { CSSStyles: {
'margin': '-10px 0px 0px -10px' 'margin': '-10px 0px 0px -10px'

6
extensions/mssql/src/objectManagement/ui/serverPropertiesDialog.ts
View File

@@ -11,6 +11,8 @@ import * as localizedConstants from '../localizedConstants';
import * as constants from '../constants'; import * as constants from '../constants';
import { Server, ServerViewInfo, NumaNode, AffinityType, ServerLoginMode, AuditLevel } from '../interfaces'; import { Server, ServerViewInfo, NumaNode, AffinityType, ServerLoginMode, AuditLevel } from '../interfaces';
const Dialog_Width = '750px';
export class ServerPropertiesDialog extends ObjectManagementDialogBase<Server, ServerViewInfo> { export class ServerPropertiesDialog extends ObjectManagementDialogBase<Server, ServerViewInfo> {
private generalTab: azdata.Tab; private generalTab: azdata.Tab;
private readonly generalTabId: string = 'generalId'; private readonly generalTabId: string = 'generalId';
@@ -90,6 +92,7 @@ export class ServerPropertiesDialog extends ObjectManagementDialogBase<Server, S
private shouldRestartServer: boolean = false; private shouldRestartServer: boolean = false;
constructor(objectManagementService: IObjectManagementService, options: ObjectManagementDialogOptions) { constructor(objectManagementService: IObjectManagementService, options: ObjectManagementDialogOptions) {
options.width = Dialog_Width;
super(objectManagementService, options); super(objectManagementService, options);
this.disposables.push(this.dialogObject.onClosed(async (reason: azdata.window.CloseReason) => { this.disposables.push(this.dialogObject.onClosed(async (reason: azdata.window.CloseReason) => {
if (reason === 'ok') { if (reason === 'ok') {
@@ -138,6 +141,9 @@ export class ServerPropertiesDialog extends ObjectManagementDialogBase<Server, S
const serverPropertiesTabGroup = { title: '', tabs: [this.generalTab, this.memoryTab, this.processorsTab, this.securityTab, this.databaseSettingsTab, this.advancedTab] }; const serverPropertiesTabGroup = { title: '', tabs: [this.generalTab, this.memoryTab, this.processorsTab, this.securityTab, this.databaseSettingsTab, this.advancedTab] };
const serverPropertiesTabbedPannel = this.modelView.modelBuilder.tabbedPanel() const serverPropertiesTabbedPannel = this.modelView.modelBuilder.tabbedPanel()
.withTabs([serverPropertiesTabGroup]) .withTabs([serverPropertiesTabGroup])
.withLayout({
orientation: azdata.TabOrientation.Vertical
})
.withProps({ .withProps({
CSSStyles: { CSSStyles: {
'margin': '-10px 0px 0px -10px' 'margin': '-10px 0px 0px -10px'