From c6564c0d8414698cf1814597de0f380620c1f315 Mon Sep 17 00:00:00 2001
From: Anthony Dresser <andresse@microsoft.com>
Date: Mon, 6 May 2019 17:25:51 -0700
Subject: [PATCH] Fix css to fix new dashboard tab dialog (#5385)

* fix css to fix new dashboard tab dialog

* add readonly
---
 .../dashboard/browser/media/newDashboardTabDialog.css  |  5 ++++-
 .../dashboard/browser/newDashboardTabDialog.ts         | 10 +++-------
 2 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/src/sql/workbench/services/dashboard/browser/media/newDashboardTabDialog.css b/src/sql/workbench/services/dashboard/browser/media/newDashboardTabDialog.css
index 7a08c2e0f9..5b1dc8cffa 100644
--- a/src/sql/workbench/services/dashboard/browser/media/newDashboardTabDialog.css
+++ b/src/sql/workbench/services/dashboard/browser/media/newDashboardTabDialog.css
@@ -47,6 +47,7 @@
 
 .extension-view .extensionTab-view .list-row.extensionTab-list .extension-details .title {
 	font-size: 15px;
+	line-height: 1.4em;
 	font-weight: 700;
 	white-space: nowrap;
 	text-overflow: ellipsis;
@@ -56,6 +57,7 @@
 
 .extension-view .extensionTab-view .list-row.extensionTab-list .extension-details .description {
 	font-size: 13px;
+	line-height: 1.4em;
 	overflow: hidden;
 	white-space: pre-wrap;
 	text-overflow: ellipsis;
@@ -63,6 +65,7 @@
 
 .extension-view .extensionTab-view .list-row.extensionTab-list .extension-details .publisher {
 	font-size: 90%;
+	line-height: 1.4em;
 	padding-right: 6px;
 	opacity: .6;
 	font-weight: 600;
@@ -71,4 +74,4 @@
 .no-extensionTab-label {
 	font-size: 12px;
 	padding: 15px;
-}
\ No newline at end of file
+}
diff --git a/src/sql/workbench/services/dashboard/browser/newDashboardTabDialog.ts b/src/sql/workbench/services/dashboard/browser/newDashboardTabDialog.ts
index 1745d38baf..41a5206395 100644
--- a/src/sql/workbench/services/dashboard/browser/newDashboardTabDialog.ts
+++ b/src/sql/workbench/services/dashboard/browser/newDashboardTabDialog.ts
@@ -30,13 +30,10 @@ import { ILogService } from 'vs/platform/log/common/log';
 
 class ExtensionListDelegate implements IListVirtualDelegate<IDashboardUITab> {
 
-	constructor(
-		private _height: number
-	) {
-	}
+	private static readonly HEIGHT = 101;
 
 	public getHeight(element: IDashboardUITab): number {
-		return this._height;
+		return ExtensionListDelegate.HEIGHT;
 	}
 
 	public getTemplateId(element: IDashboardUITab): string {
@@ -92,7 +89,6 @@ class ExtensionListRenderer implements IListRenderer<IDashboardUITab, ExtensionL
 }
 
 export class NewDashboardTabDialog extends Modal {
-	public static EXTENSIONLIST_HEIGHT = 101;
 
 	// MEMBER letIABLES ////////////////////////////////////////////////////
 	private _addNewTabButton: Button;
@@ -168,7 +164,7 @@ export class NewDashboardTabDialog extends Modal {
 	private createExtensionList(container: HTMLElement) {
 		// Create a fixed list view for the extensions
 		let extensionTabViewContainer = DOM.$('.extensionTab-view');
-		let delegate = new ExtensionListDelegate(NewDashboardTabDialog.EXTENSIONLIST_HEIGHT);
+		let delegate = new ExtensionListDelegate();
 		let extensionTabRenderer = new ExtensionListRenderer();
 		this._extensionList = new List<IDashboardUITab>(extensionTabViewContainer, delegate, [extensionTabRenderer]);