ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-14 01:25:37 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add no-floating-promises rule to sql-database-projects extension (#16943)

Browse Source 
* Add no-floating-promises rule to sql-database-projects extension

* fix test
This commit is contained in:
Charles Gagnon
2021-08-31 14:13:52 -07:00
committed by GitHub
parent af135c0d71
commit c8cc6c08e9
13 changed files with 84 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
extensions/sql-database-projects/src/controllers/projectController.ts
View File

@@ -247,9 +247,9 @@ export class ProjectsController {
const message = utils.getErrorMessage(err);
if (err instanceof DotNetError) {
vscode.window.showErrorMessage(message);
void vscode.window.showErrorMessage(message);
} else {
vscode.window.showErrorMessage(constants.projBuildFailed(message));
void vscode.window.showErrorMessage(constants.projBuildFailed(message));
}
return '';
}
@@ -281,16 +281,16 @@ export class ProjectsController {
if (deployProfile.localDbSetting) {
await this.deployService.getConnection(deployProfile.localDbSetting, true, deployProfile.localDbSetting.dbName);
}
vscode.window.showInformationMessage(constants.deployProjectSucceed);
void vscode.window.showInformationMessage(constants.deployProjectSucceed);
} else {
vscode.window.showErrorMessage(constants.deployProjectFailed(publishResult?.errorMessage || ''));
void vscode.window.showErrorMessage(constants.deployProjectFailed(publishResult?.errorMessage || ''));
}
} else {
vscode.window.showErrorMessage(constants.deployProjectFailed(constants.deployProjectFailedMessage));
void vscode.window.showErrorMessage(constants.deployProjectFailed(constants.deployProjectFailedMessage));
}
}
} catch (error) {
vscode.window.showErrorMessage(constants.deployProjectFailed(utils.getErrorMessage(error)));
void vscode.window.showErrorMessage(constants.deployProjectFailed(utils.getErrorMessage(error)));
}
return;
}
@@ -318,7 +318,7 @@ export class ProjectsController {
return publishDatabaseDialog;
} else {
launchPublishDatabaseQuickpick(project, this);
void launchPublishDatabaseQuickpick(project, this);
return undefined;
}
}
@@ -447,7 +447,7 @@ export class ProjectsController {
.withAdditionalProperties(props)
.send();
vscode.window.showErrorMessage(utils.getErrorMessage(err));
void vscode.window.showErrorMessage(utils.getErrorMessage(err));
}
}
@@ -476,7 +476,7 @@ export class ProjectsController {
await project.addFolderItem(relativeFolderPath);
this.refreshProjectsTree(treeNode);
} catch (err) {
vscode.window.showErrorMessage(utils.getErrorMessage(err));
void vscode.window.showErrorMessage(utils.getErrorMessage(err));
}
}
@@ -540,7 +540,7 @@ export class ProjectsController {
await vscode.commands.executeCommand(constants.vscodeOpenCommand, newEntry.fsUri);
treeDataProvider?.notifyTreeDataChanged();
} catch (err) {
vscode.window.showErrorMessage(utils.getErrorMessage(err));
void vscode.window.showErrorMessage(utils.getErrorMessage(err));
TelemetryReporter.createErrorEvent(TelemetryViews.ProjectTree, TelemetryActions.addItemFromTree)
.withAdditionalProperties(telemetryProps)
@@ -560,7 +560,7 @@ export class ProjectsController {
await project.exclude(fileEntry);
} else {
TelemetryReporter.sendErrorEvent(TelemetryViews.ProjectTree, TelemetryActions.excludeFromProject);
vscode.window.showErrorMessage(constants.unableToPerformAction(constants.excludeAction, node.projectUri.path));
void vscode.window.showErrorMessage(constants.unableToPerformAction(constants.excludeAction, node.projectUri.path));
}
this.refreshProjectsTree(context);
@@ -614,7 +614,7 @@ export class ProjectsController {
.withAdditionalProperties({ objectType: node.constructor.name })
.send();
vscode.window.showErrorMessage(constants.unableToPerformAction(constants.deleteAction, node.projectUri.path));
void vscode.window.showErrorMessage(constants.unableToPerformAction(constants.deleteAction, node.projectUri.path));
}
}
@@ -670,7 +670,7 @@ export class ProjectsController {
const result = await vscode.window.showInformationMessage(constants.reloadProject, constants.yesString, constants.noString);
if (result === constants.yesString) {
this.reloadProject(context);
return this.reloadProject(context);
}
});
@@ -683,7 +683,7 @@ export class ProjectsController {
}
});
} catch (err) {
vscode.window.showErrorMessage(utils.getErrorMessage(err));
void vscode.window.showErrorMessage(utils.getErrorMessage(err));
}
}
@@ -716,7 +716,7 @@ export class ProjectsController {
if (selectedTargetPlatform) {
await project.changeTargetPlatform(constants.targetPlatformToVersion.get(selectedTargetPlatform)!);
vscode.window.showInformationMessage(constants.currentTargetPlatform(project.projectFileName, constants.getTargetPlatformFromVersion(project.getProjectTargetVersion())));
void vscode.window.showInformationMessage(constants.currentTargetPlatform(project.projectFileName, constants.getTargetPlatformFromVersion(project.getProjectTargetVersion())));
}
}
@@ -731,7 +731,7 @@ export class ProjectsController {
const addDatabaseReferenceDialog = this.getAddDatabaseReferenceDialog(project);
addDatabaseReferenceDialog.addReference = async (proj, settings) => await this.addDatabaseReferenceCallback(proj, settings, context as dataworkspace.WorkspaceTreeItem);
addDatabaseReferenceDialog.openDialog();
await addDatabaseReferenceDialog.openDialog();
return addDatabaseReferenceDialog;
} else {
const settings = await addDatabaseReferenceQuickpick(project);
@@ -767,7 +767,7 @@ export class ProjectsController {
// check for cirular dependency
for (let r of projectReferences) {
if ((<SqlProjectReferenceProjectEntry>r).projectName === project.projectFileName) {
vscode.window.showErrorMessage(constants.cantAddCircularProjectReference(referencedProject?.projectFileName!));
void vscode.window.showErrorMessage(constants.cantAddCircularProjectReference(referencedProject?.projectFileName!));
return;
}
}
@@ -784,7 +784,7 @@ export class ProjectsController {
this.refreshProjectsTree(context);
} catch (err) {
vscode.window.showErrorMessage(utils.getErrorMessage(err));
void vscode.window.showErrorMessage(utils.getErrorMessage(err));
}
}
@@ -817,10 +817,10 @@ export class ProjectsController {
telemetryProps.success = result.success.toString();
if (result.success) {
vscode.window.showInformationMessage(constants.externalStreamingJobValidationPassed);
void vscode.window.showInformationMessage(constants.externalStreamingJobValidationPassed);
}
else {
vscode.window.showErrorMessage(result.errorMessage);
void vscode.window.showErrorMessage(result.errorMessage);
}
TelemetryReporter.createActionEvent(TelemetryViews.ProjectTree, TelemetryActions.runStreamingJobValidation)
@@ -985,7 +985,7 @@ export class ProjectsController {
await workspaceApi.addProjectsToWorkspace([vscode.Uri.file(newProjFilePath)]);
}
} catch (err) {
vscode.window.showErrorMessage(utils.getErrorMessage(err));
void vscode.window.showErrorMessage(utils.getErrorMessage(err));
}
}
@@ -1027,7 +1027,7 @@ export class ProjectsController {
if (await utils.exists(absolutePath + constants.sqlFileExtension)) {
absolutePath += constants.sqlFileExtension;
} else {
vscode.window.showErrorMessage(constants.cannotResolvePath(absolutePath));
void vscode.window.showErrorMessage(constants.cannotResolvePath(absolutePath));
return fileFolderList;
}
}