Add no-floating-promises rule to sql-database-projects extension (#16943)

* Add no-floating-promises rule to sql-database-projects extension

* fix test
This commit is contained in:
Charles Gagnon
2021-08-31 14:13:52 -07:00
committed by GitHub
parent af135c0d71
commit c8cc6c08e9
13 changed files with 84 additions and 71 deletions

View File

@@ -123,7 +123,7 @@ export class CreateProjectFromDatabaseDialog {
let formModel = this.formBuilder.component();
await view.initializeModel(formModel);
this.selectConnectionButton?.focus();
await this.selectConnectionButton?.focus();
this.initDialogComplete?.resolve();
});
}
@@ -209,7 +209,7 @@ export class CreateProjectFromDatabaseDialog {
private async updateConnectionComponents(connectionTextboxValue: string, connectionId: string, databaseName?: string) {
this.sourceConnectionTextBox!.value = connectionTextboxValue;
this.sourceConnectionTextBox!.updateProperty('title', connectionTextboxValue);
void this.sourceConnectionTextBox!.updateProperty('title', connectionTextboxValue);
// populate database dropdown with the databases for this connection
if (connectionId) {
@@ -249,7 +249,7 @@ export class CreateProjectFromDatabaseDialog {
this.projectNameTextBox.onTextChanged(() => {
this.projectNameTextBox!.value = this.projectNameTextBox!.value?.trim();
this.projectNameTextBox!.updateProperty('title', this.projectNameTextBox!.value);
void this.projectNameTextBox!.updateProperty('title', this.projectNameTextBox!.value);
this.tryEnableCreateButton();
});
@@ -275,7 +275,7 @@ export class CreateProjectFromDatabaseDialog {
}).component();
this.projectLocationTextBox.onTextChanged(() => {
this.projectLocationTextBox!.updateProperty('title', this.projectLocationTextBox!.value);
void this.projectLocationTextBox!.updateProperty('title', this.projectLocationTextBox!.value);
this.tryEnableCreateButton();
});
@@ -312,7 +312,7 @@ export class CreateProjectFromDatabaseDialog {
}
this.projectLocationTextBox!.value = folderUris[0].fsPath;
this.projectLocationTextBox!.updateProperty('title', folderUris[0].fsPath);
void this.projectLocationTextBox!.updateProperty('title', folderUris[0].fsPath);
});
return browseFolderButton;