ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-15 17:22:25 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add no-floating-promises rule to sql-database-projects extension (#16943)

Browse Source 
* Add no-floating-promises rule to sql-database-projects extension

* fix test
This commit is contained in:
Charles Gagnon
2021-08-31 14:13:52 -07:00
committed by GitHub
parent af135c0d71
commit c8cc6c08e9
13 changed files with 84 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts
View File

@@ -146,7 +146,7 @@ export class PublishDatabaseDialog {
let formModel = this.formBuilder.component();
await view.initializeModel(formModel);
this.loadProfileTextBox!.focus();
await this.loadProfileTextBox!.focus();
});
}
@@ -464,7 +464,7 @@ export class PublishDatabaseDialog {
this.sqlCmdVars = { ...this.project.sqlCmdVariables };
const data = this.convertSqlCmdVarsToTableFormat(this.sqlCmdVars!);
(<azdataType.DeclarativeTableComponent>this.sqlCmdVariablesTable)!.updateProperties({
await (<azdataType.DeclarativeTableComponent>this.sqlCmdVariablesTable)!.updateProperties({
dataValues: data
});
@@ -489,7 +489,7 @@ export class PublishDatabaseDialog {
let connectionTextboxValue: string = getConnectionName(connection);
this.updateConnectionComponents(connectionTextboxValue, this.connectionId);
await this.updateConnectionComponents(connectionTextboxValue, this.connectionId);
// change the database inputbox value to the connection's database if there is one
if (connection.options.database && connection.options.database !== constants.master) {
@@ -505,7 +505,7 @@ export class PublishDatabaseDialog {
private async updateConnectionComponents(connectionTextboxValue: string, connectionId: string) {
this.targetConnectionTextBox!.value = connectionTextboxValue;
this.targetConnectionTextBox!.updateProperty('title', connectionTextboxValue);
await this.targetConnectionTextBox!.updateProperty('title', connectionTextboxValue);
// populate database dropdown with the databases for this connection
if (connectionId) {
@@ -569,7 +569,7 @@ export class PublishDatabaseDialog {
// show file path in text box and hover text
this.loadProfileTextBox!.value = fileUris[0].fsPath;
this.loadProfileTextBox!.updateProperty('title', fileUris[0].fsPath);
await this.loadProfileTextBox!.updateProperty('title', fileUris[0].fsPath);
}
});