ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-17 01:25:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add no-floating-promises rule to sql-database-projects extension (#16943)

Browse Source 
* Add no-floating-promises rule to sql-database-projects extension

* fix test
This commit is contained in:
Charles Gagnon
2021-08-31 14:13:52 -07:00
committed by GitHub
parent af135c0d71
commit c8cc6c08e9
13 changed files with 84 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
extensions/sql-database-projects/src/models/project.ts
View File

@@ -150,7 +150,7 @@ export class Project implements ISqlProject {
}
if (preDeployScriptCount > 1 || postDeployScriptCount > 1) {
window.showWarningMessage(constants.prePostDeployCount, constants.okString);
void window.showWarningMessage(constants.prePostDeployCount, constants.okString);
}
// find all none-deployment scripts to include
@@ -630,7 +630,7 @@ export class Project implements ISqlProject {
itemGroup = this.findOrCreateItemGroup(xmlTag, prePostScriptExist);
if (prePostScriptExist.scriptExist === true) {
window.showInformationMessage(constants.deployScriptExists(xmlTag));
void window.showInformationMessage(constants.deployScriptExists(xmlTag));
xmlTag = constants.None; // Add only one pre-deploy and post-deploy script. All additional ones get added in the same item group with None tag
}
}

2
extensions/sql-database-projects/src/models/publishProfile/publishProfile.ts
View File

@@ -29,7 +29,7 @@ export async function readPublishProfile(profileUri: vscode.Uri): Promise<Publis
const profile = await load(profileUri, dacFxService);
return profile;
} catch (e) {
vscode.window.showErrorMessage(constants.profileReadError(e));
void vscode.window.showErrorMessage(constants.profileReadError(e));
throw e;
}
}