ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-17 17:22:42 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add no-floating-promises rule to sql-database-projects extension (#16943)

Browse Source 
* Add no-floating-promises rule to sql-database-projects extension

* fix test
This commit is contained in:
Charles Gagnon
2021-08-31 14:13:52 -07:00
committed by GitHub
parent af135c0d71
commit c8cc6c08e9
13 changed files with 84 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
extensions/sql-database-projects/src/tools/netcoreTool.ts
View File

@@ -53,7 +53,7 @@ export class NetCoreTool {
public async findOrInstallNetCore(): Promise<boolean> {
if ((!this.isNetCoreInstallationPresent || !await this.isNetCoreVersionSupported())) {
if (vscode.workspace.getConfiguration(DBProjectConfigurationKey)[NetCoreDoNotAskAgainKey] !== true) {
this.showInstallDialog(); // Removing await so that Build and extension load process doesn't wait on user input
void this.showInstallDialog(); // Removing await so that Build and extension load process doesn't wait on user input
}
return false;
}
@@ -226,7 +226,7 @@ export class NetCoreTool {
outputChannel.show();
// Add listeners to print stdout and stderr and exit code
child.on('exit', (code: number | null, signal: string | null) => {
void child.on('exit', (code: number | null, signal: string | null) => {
if (code !== null) {
outputChannel.appendLine(localize('sqlDatabaseProjects.RunStreamedCommand.ExitedWithCode', " >>> {0} … exited with code: {1}", command, code));
} else {

4
extensions/sql-database-projects/src/tools/packageHelper.ts
View File

@@ -66,7 +66,7 @@ export class PackageHelper {
await this.addPackage(project, packageName, packageVersion);
}
} catch (e) {
vscode.window.showErrorMessage(e.message);
void vscode.window.showErrorMessage(e.message);
}
}
@@ -85,7 +85,7 @@ export class PackageHelper {
// TODO: figure out which project contains the file
// the new style csproj doesn't list all the files in the project anymore, unless the file isn't in the same folder
// so we can't rely on using that to check
vscode.window.showInformationMessage(`To use SQL bindings, ensure your Azure Functions project has a reference to ${constants.sqlExtensionPackageName}`);
void vscode.window.showInformationMessage(`To use SQL bindings, ensure your Azure Functions project has a reference to ${constants.sqlExtensionPackageName}`);
console.error('need to find which project contains the file ' + filePath);
return undefined;
} else if (functionsProjects.length === 0) {