ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Disable schema compare generate script and apply buttons after applying changes (#5759)

Browse Source 
* disable generate script and apply buttons after applying changes

* reenable buttons if apply failed
This commit is contained in:
kisantia
2019-05-30 14:08:47 -07:00
committed by GitHub
parent 783bb8bd92
commit c9257822ec
1 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
extensions/schema-compare/src/schemaCompareResult.ts
View File

@@ -14,6 +14,9 @@ import { getTelemetryErrorType } from './utils';
const localize = nls.loadMessageBundle(); const localize = nls.loadMessageBundle();
const diffEditorTitle = localize('schemaCompare.ObjectDefinitionsTitle', 'Object Definitions'); const diffEditorTitle = localize('schemaCompare.ObjectDefinitionsTitle', 'Object Definitions');
const applyConfirmation = localize('schemaCompare.ApplyConfirmation', 'Are you sure you want to update the target?'); const applyConfirmation = localize('schemaCompare.ApplyConfirmation', 'Are you sure you want to update the target?');
const reCompareToRefeshMessage = localize('schemaCompare.RecompareToRefresh', 'Press Compare to refresh the comparison.');
const generateScriptEnabledMessage = localize('schemaCompare.generateScriptEnabledButton', 'Generate script to deploy changes to target');
const applyEnabledMessage = localize('schemaCompare.applyButtonEnabledTitle', 'Apply changes to target');
export class SchemaCompareResult { export class SchemaCompareResult {
private differencesTable: azdata.TableComponent; private differencesTable: azdata.TableComponent;
@@ -493,6 +496,13 @@ export class SchemaCompareResult {
'startTime': Date.now().toString(), 'startTime': Date.now().toString(),
'operationId': this.comparisonResult.operationId 'operationId': this.comparisonResult.operationId
}); });
// disable apply and generate script buttons because the results are no longer valid after applying the changes
this.generateScriptButton.enabled = false;
this.generateScriptButton.title = reCompareToRefeshMessage;
this.applyButton.enabled = false;
this.applyButton.title = reCompareToRefeshMessage;
const service = await SchemaCompareResult.getService('MSSQL'); const service = await SchemaCompareResult.getService('MSSQL');
const result = await service.schemaComparePublishChanges(this.comparisonResult.operationId, this.targetEndpointInfo.serverName, this.targetEndpointInfo.databaseName, azdata.TaskExecutionMode.execute); const result = await service.schemaComparePublishChanges(this.comparisonResult.operationId, this.targetEndpointInfo.serverName, this.targetEndpointInfo.databaseName, azdata.TaskExecutionMode.execute);
if (!result || !result.success) { if (!result || !result.success) {
@@ -502,6 +512,12 @@ export class SchemaCompareResult {
}); });
vscode.window.showErrorMessage( vscode.window.showErrorMessage(
localize('schemaCompare.updateErrorMessage', "Schema Compare Apply failed '{0}'", result.errorMessage ? result.errorMessage : 'Unknown')); localize('schemaCompare.updateErrorMessage', "Schema Compare Apply failed '{0}'", result.errorMessage ? result.errorMessage : 'Unknown'));
// reenable generate script and apply buttons if apply failed
this.generateScriptButton.enabled = true;
this.generateScriptButton.title = generateScriptEnabledMessage;
this.applyButton.enabled = true;
this.applyButton.title = applyEnabledMessage;
} }
Telemetry.sendTelemetryEvent('SchemaCompareApplyEnded', { Telemetry.sendTelemetryEvent('SchemaCompareApplyEnded', {
'endTime': Date.now().toString(), 'endTime': Date.now().toString(),
@@ -525,8 +541,8 @@ export class SchemaCompareResult {
} }
this.generateScriptButton.enabled = false; this.generateScriptButton.enabled = false;
this.applyButton.enabled = false; this.applyButton.enabled = false;
this.generateScriptButton.title = localize('schemaCompare.generateScriptEnabledButton', 'Generate script to deploy changes to target'); this.generateScriptButton.title = generateScriptEnabledMessage;
this.applyButton.title = localize('schemaCompare.applyButtonEnabledTitle', 'Apply changes to target'); this.applyButton.title = applyEnabledMessage;
} }
private createSwitchButton(view: azdata.ModelView): void { private createSwitchButton(view: azdata.ModelView): void {