Bug/extension contribution (#2560)

* revert 4ab5d84b94

* fixed extensions
This commit is contained in:
Aditya Bist
2018-09-12 23:04:59 -07:00
committed by Karl Burtram
parent 10875f26dc
commit c92b88bfaf
4 changed files with 12 additions and 28 deletions

View File

@@ -48,9 +48,7 @@ export abstract class Task {
id: this.id,
handler: (accessor, profile, args) => this.runTask(accessor, profile, args),
description: this._description,
iconClass: this._iconClass,
iconPath: this.opts.iconPath,
title: this.title
iconClass: this._iconClass
};
}
@@ -62,10 +60,8 @@ export abstract class Task {
};
}
public registerTask(showInCommandPalette: boolean = true): IDisposable {
if (showInCommandPalette) {
MenuRegistry.addCommand(this.toCommandAction());
}
public registerTask(): IDisposable {
MenuRegistry.addCommand(this.toCommandAction());
return TaskRegistry.registerTask(this.toITask());
}
@@ -100,8 +96,6 @@ export interface ITask {
precondition?: ContextKeyExpr;
description?: ITaskHandlerDescription;
iconClass?: string;
iconPath?: { dark: string; light?: string; };
title?: string;
}
export interface ITaskRegistry {
@@ -110,7 +104,6 @@ export interface ITaskRegistry {
getTasks(): string[];
getOrCreateTaskIconClassName(item: ICommandAction): string;
onTaskRegistered: Event<string>;
getCommandActionById(id: string): ICommandAction;
}
const ids = new IdGenerator('task-icon-');
@@ -121,7 +114,6 @@ export const TaskRegistry: ITaskRegistry = new class implements ITaskRegistry {
private _onTaskRegistered = new Emitter<string>();
public readonly onTaskRegistered: Event<string> = this._onTaskRegistered.event;
private taskIdToIconClassNameMap: Map<string /* task id */, string /* CSS rule */> = new Map<string, string>();
private taskIdToCommandActionMap: Map<string, ICommandAction> = new Map<string, ICommandAction>();
registerTask(idOrTask: string | ITask, handler?: ITaskHandler): IDisposable {
let disposable: IDisposable;
@@ -133,16 +125,6 @@ export const TaskRegistry: ITaskRegistry = new class implements ITaskRegistry {
if (idOrTask.iconClass) {
this.taskIdToIconClassNameMap.set(idOrTask.id, idOrTask.iconClass);
}
if (idOrTask.iconPath && idOrTask.title) {
this.taskIdToCommandActionMap.set(idOrTask.id, {
iconLocation: {
dark: URI.parse(idOrTask.iconPath.dark),
light: URI.parse(idOrTask.iconPath.light),
},
id: idOrTask.id,
title: idOrTask.title
});
}
disposable = CommandsRegistry.registerCommand(idOrTask);
id = idOrTask.id;
}
@@ -177,8 +159,4 @@ export const TaskRegistry: ITaskRegistry = new class implements ITaskRegistry {
getTasks(): string[] {
return this._tasks.slice(0);
}
getCommandActionById(taskId: string): ICommandAction {
return this.taskIdToCommandActionMap.get(taskId);
}
};