From cacd481bff25c890e4130aee392569bae43b7e60 Mon Sep 17 00:00:00 2001 From: Charles Gagnon Date: Fri, 1 Nov 2019 15:56:48 -0700 Subject: [PATCH] Fix ssl config issue --- extensions/big-data-cluster/src/bigDataCluster/utils.ts | 3 ++- extensions/mssql/src/util/auth.ts | 3 ++- extensions/notebook/src/common/utils.ts | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/extensions/big-data-cluster/src/bigDataCluster/utils.ts b/extensions/big-data-cluster/src/bigDataCluster/utils.ts index c7df2e5ad9..22789161b6 100644 --- a/extensions/big-data-cluster/src/bigDataCluster/utils.ts +++ b/extensions/big-data-cluster/src/bigDataCluster/utils.ts @@ -281,7 +281,8 @@ export const ignoreSslConfigName = 'ignoreSslVerification'; export function getIgnoreSslVerificationConfigSetting(): boolean { try { const config = vscode.workspace.getConfiguration(bdcConfigSectionName); - return config.get(ignoreSslConfigName) || true; + const value = config.get(ignoreSslConfigName); + return value !== undefined ? value : true; } catch (error) { console.error(`Unexpected error retrieving ${bdcConfigSectionName}.${ignoreSslConfigName} setting : ${error}`); } diff --git a/extensions/mssql/src/util/auth.ts b/extensions/mssql/src/util/auth.ts index e1d495331c..1cb1f32737 100644 --- a/extensions/mssql/src/util/auth.ts +++ b/extensions/mssql/src/util/auth.ts @@ -28,7 +28,8 @@ const ignoreSslConfigName = 'ignoreSslVerification'; export function getIgnoreSslVerificationConfigSetting(): boolean { try { const config = vscode.workspace.getConfiguration(bdcConfigSectionName); - return config.get(ignoreSslConfigName) || true; + const value = config.get(ignoreSslConfigName); + return value !== undefined ? value : true; } catch (error) { console.error(`Unexpected error retrieving ${bdcConfigSectionName}.${ignoreSslConfigName} setting : ${error}`); } diff --git a/extensions/notebook/src/common/utils.ts b/extensions/notebook/src/common/utils.ts index 31912f6153..263e3f107f 100644 --- a/extensions/notebook/src/common/utils.ts +++ b/extensions/notebook/src/common/utils.ts @@ -256,7 +256,8 @@ const ignoreSslConfigName = 'ignoreSslVerification'; export function getIgnoreSslVerificationConfigSetting(): boolean { try { const config = vscode.workspace.getConfiguration(bdcConfigSectionName); - return config.get(ignoreSslConfigName) || true; + const value = config.get(ignoreSslConfigName); + return value !== undefined ? value : true; } catch (error) { console.error(`Unexpected error retrieving ${bdcConfigSectionName}.${ignoreSslConfigName} setting : ${error}`); }