ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-14 03:58:33 -05:00
Code Issues Packages Projects Releases Wiki Activity

Correctly announce loading state for arc cluster context loading (#15747)

Browse Source 
* Correctly announce loading state for arc cluster context loading

* localize

* Fix compile

* Fix test
This commit is contained in:
Charles Gagnon
2021-06-17 10:28:12 -07:00
committed by GitHub
parent 7c3a7e2646
commit cae598d36c
6 changed files with 32 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
extensions/arc/src/ui/dialogs/connectControllerDialog.ts
View File

@@ -97,13 +97,14 @@ abstract class ControllerDialogBase extends InitializingComponent {
this.modelBuilder,
controllerInfo?.kubeConfigFilePath || getDefaultKubeConfigPath(),
(disposable) => this._toDispose.push(disposable),
loc.controllerKubeConfig
loc.controllerKubeConfig,
loc.invalidConfigPath
);
this.modelBuilder.inputBox()
.withProps({
value: controllerInfo?.kubeConfigFilePath || getDefaultKubeConfigPath()
}).component();
this.clusterContextRadioGroup = new RadioOptionsGroup(this.modelBuilder, (disposable) => this._toDispose.push(disposable));
this.clusterContextRadioGroup = new RadioOptionsGroup(this.modelBuilder, (disposable) => this._toDispose.push(disposable), undefined, loc.loadingClusterContextCompleted, loc.loadingClusterContextsError);
this.loadRadioGroup(controllerInfo?.kubeClusterContext);
this._toDispose.push(this.clusterContextRadioGroup.onRadioOptionChanged(newContext => this.updateNamespace(newContext)));
this._toDispose.push(this.kubeConfigInputBox.onTextChanged(() => this.loadRadioGroup(controllerInfo?.kubeClusterContext)));