No kernel is shown when open a new notebook from command palette (#3374)

Fixes #3271. Ensure a provider is defined when opening through command palette
This commit is contained in:
Raj
2018-12-03 18:12:25 -08:00
committed by Kevin Cunnane
parent 86e54ce145
commit cb162b16f2
2 changed files with 18 additions and 2 deletions

View File

@@ -86,11 +86,17 @@ export class NotebookService implements INotebookService {
// PRIVATE HELPERS /////////////////////////////////////////////////////
private doWithProvider<T>(providerId: string, op: (provider: INotebookProvider) => Thenable<T>): Thenable<T> {
// Make sure the provider exists before attempting to retrieve accounts
let provider = this._providers.get(providerId);
let provider: INotebookProvider;
if (this._providers.has(providerId)) {
provider = this._providers.get(providerId);
}
else {
provider = this._providers.get(DEFAULT_NOTEBOOK_PROVIDER);
}
if (!provider) {
return Promise.reject(new Error(localize('notebookServiceNoProvider', 'Notebook provider does not exist'))).then();
}
return op(provider);
}