ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Changed cores validation message (#13617)

Browse Source 
* Changed cores validation message

* Missed validation

* Remove cores validation message

* Applied verification for cores change to miaa c+s page
This commit is contained in:
nasc17
2020-12-02 15:22:35 -08:00
committed by GitHub
parent 40675fcadb
commit cb567989da
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/arc/src/localizedConstants.ts
View File

@@ -139,7 +139,6 @@ export const coresRequest = localize('arc.coresRequest', "CPU request:");
export const memoryLimit = localize('arc.memoryLimit', "Memory limit (in GB):"); export const memoryLimit = localize('arc.memoryLimit', "Memory limit (in GB):");
export const memoryRequest = localize('arc.memoryRequest', "Memory request (in GB):"); export const memoryRequest = localize('arc.memoryRequest', "Memory request (in GB):");
export const workerValidationErrorMessage = localize('arc.workerValidationErrorMessage', "The number of workers cannot be decreased."); export const workerValidationErrorMessage = localize('arc.workerValidationErrorMessage', "The number of workers cannot be decreased.");
export const coresValidationErrorMessage = localize('arc.coresValidationErrorMessage', "Valid CPU resource quantities are strictly positive.");
export const memoryRequestValidationErrorMessage = localize('arc.memoryRequestValidationErrorMessage', "Memory request must be at least 0.25Gib"); export const memoryRequestValidationErrorMessage = localize('arc.memoryRequestValidationErrorMessage', "Memory request must be at least 0.25Gib");
export const memoryLimitValidationErrorMessage = localize('arc.memoryLimitValidationErrorMessage', "Memory limit must be at least 0.25Gib"); export const memoryLimitValidationErrorMessage = localize('arc.memoryLimitValidationErrorMessage', "Memory limit must be at least 0.25Gib");
export const arcResources = localize('arc.arcResources', "Azure Arc Resources"); export const arcResources = localize('arc.arcResources', "Azure Arc Resources");
@@ -172,6 +171,7 @@ export function numVCores(vCores: string | undefined): string {
} }
} }
export function updated(when: string): string { return localize('arc.updated', "Updated {0}", when); } export function updated(when: string): string { return localize('arc.updated', "Updated {0}", when); }
export function validationMin(min: number): string { return localize('arc.validationMin', "Value must be greater than or equal to {0}.", min); }
// Errors // Errors
export const connectionRequired = localize('arc.connectionRequired', "A connection is required to show all properties. Click refresh to re-enter connection information"); export const connectionRequired = localize('arc.connectionRequired', "A connection is required to show all properties. Click refresh to re-enter connection information");

4
extensions/arc/src/ui/dashboards/miaa/miaaComputeAndStoragePage.ts
View File

@@ -179,7 +179,6 @@ export class MiaaComputeAndStoragePage extends DashboardPage {
this.coresLimitBox = this.modelView.modelBuilder.inputBox().withProperties<azdata.InputBoxProperties>({ this.coresLimitBox = this.modelView.modelBuilder.inputBox().withProperties<azdata.InputBoxProperties>({
readOnly: false, readOnly: false,
min: 1, min: 1,
validationErrorMessage: loc.coresValidationErrorMessage,
inputType: 'number', inputType: 'number',
placeHolder: loc.loading placeHolder: loc.loading
}).component(); }).component();
@@ -197,7 +196,6 @@ export class MiaaComputeAndStoragePage extends DashboardPage {
this.coresRequestBox = this.modelView.modelBuilder.inputBox().withProperties<azdata.InputBoxProperties>({ this.coresRequestBox = this.modelView.modelBuilder.inputBox().withProperties<azdata.InputBoxProperties>({
readOnly: false, readOnly: false,
min: 1, min: 1,
validationErrorMessage: loc.coresValidationErrorMessage,
inputType: 'number', inputType: 'number',
placeHolder: loc.loading placeHolder: loc.loading
}).component(); }).component();
@@ -318,6 +316,7 @@ export class MiaaComputeAndStoragePage extends DashboardPage {
currentCPUSize = ''; currentCPUSize = '';
} }
this.coresRequestBox!.validationErrorMessage = loc.validationMin(this.coresRequestBox!.min!);
this.coresRequestBox!.placeHolder = currentCPUSize; this.coresRequestBox!.placeHolder = currentCPUSize;
this.coresRequestBox!.value = ''; this.coresRequestBox!.value = '';
this.saveArgs.coresRequest = undefined; this.saveArgs.coresRequest = undefined;
@@ -328,6 +327,7 @@ export class MiaaComputeAndStoragePage extends DashboardPage {
currentCPUSize = ''; currentCPUSize = '';
} }
this.coresLimitBox!.validationErrorMessage = loc.validationMin(this.coresLimitBox!.min!);
this.coresLimitBox!.placeHolder = currentCPUSize; this.coresLimitBox!.placeHolder = currentCPUSize;
this.coresLimitBox!.value = ''; this.coresLimitBox!.value = '';
this.saveArgs.coresLimit = undefined; this.saveArgs.coresLimit = undefined;

4
extensions/arc/src/ui/dashboards/postgres/postgresComputeAndStoragePage.ts
View File

@@ -225,7 +225,6 @@ export class PostgresComputeAndStoragePage extends DashboardPage {
this.coresLimitBox = this.modelView.modelBuilder.inputBox().withProperties<azdata.InputBoxProperties>({ this.coresLimitBox = this.modelView.modelBuilder.inputBox().withProperties<azdata.InputBoxProperties>({
readOnly: false, readOnly: false,
min: 1, min: 1,
validationErrorMessage: loc.coresValidationErrorMessage,
inputType: 'number', inputType: 'number',
placeHolder: loc.loading placeHolder: loc.loading
}).component(); }).component();
@@ -243,7 +242,6 @@ export class PostgresComputeAndStoragePage extends DashboardPage {
this.coresRequestBox = this.modelView.modelBuilder.inputBox().withProperties<azdata.InputBoxProperties>({ this.coresRequestBox = this.modelView.modelBuilder.inputBox().withProperties<azdata.InputBoxProperties>({
readOnly: false, readOnly: false,
min: 1, min: 1,
validationErrorMessage: loc.coresValidationErrorMessage,
inputType: 'number', inputType: 'number',
placeHolder: loc.loading placeHolder: loc.loading
}).component(); }).component();
@@ -448,6 +446,7 @@ export class PostgresComputeAndStoragePage extends DashboardPage {
currentCPUSize = ''; currentCPUSize = '';
} }
this.coresRequestBox!.validationErrorMessage = loc.validationMin(this.coresRequestBox!.min!);
this.coresRequestBox!.placeHolder = currentCPUSize; this.coresRequestBox!.placeHolder = currentCPUSize;
this.coresRequestBox!.value = ''; this.coresRequestBox!.value = '';
this.saveArgs.coresRequest = undefined; this.saveArgs.coresRequest = undefined;
@@ -458,6 +457,7 @@ export class PostgresComputeAndStoragePage extends DashboardPage {
currentCPUSize = ''; currentCPUSize = '';
} }
this.coresLimitBox!.validationErrorMessage = loc.validationMin(this.coresLimitBox!.min!);
this.coresLimitBox!.placeHolder = currentCPUSize; this.coresLimitBox!.placeHolder = currentCPUSize;
this.coresLimitBox!.value = ''; this.coresLimitBox!.value = '';
this.saveArgs.coresLimit = undefined; this.saveArgs.coresLimit = undefined;