ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-23 01:25:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add more Azure account logging (#16847)

Browse Source 
* logging 1

* More logging

* more logging

* Handle each tenant separately.

* cleanup
This commit is contained in:
Charles Gagnon
2021-08-20 13:23:36 -07:00
committed by GitHub
parent 5b3fbaa5ff
commit ccaf111696
4 changed files with 85 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/sql/workbench/services/accountManagement/browser/accountDialog.ts
View File

@@ -305,8 +305,10 @@ export class AccountDialog extends Modal {
// PRIVATE HELPERS /////////////////////////////////////////////////////
private addProvider(newProvider: AccountProviderAddedEventParams) {
this.logService.debug(`Adding new provider ${newProvider.addedProvider.id}`);
// Skip adding the provider if it already exists
if (this._providerViewsMap.get(newProvider.addedProvider.id)) {
this.logService.debug(`Provider ${newProvider.addedProvider.id} is already registered!`);
return;
}
@@ -364,14 +366,17 @@ export class AccountDialog extends Modal {
this.layout();
this.logService.debug(`Storing view for provider ${newProvider.addedProvider.id}`);
// Store the view for the provider and action
this._providerViewsMap.set(newProvider.addedProvider.id, { view: providerView, addAccountAction: addAccountAction });
}
private removeProvider(removedProvider: azdata.AccountProviderMetadata) {
this.logService.debug(`Removing provider ${removedProvider.id}`);
// Skip removing the provider if it doesn't exist
const providerView = this._providerViewsMap.get(removedProvider.id);
if (!providerView || !providerView.view) {
this.logService.warn(`Provider ${removedProvider.id} doesn't exist while removing`);
return;
}
@@ -381,6 +386,7 @@ export class AccountDialog extends Modal {
// Remove the list view from our internal map
this._providerViewsMap.delete(removedProvider.id);
this.logService.debug(`Provider ${removedProvider.id} removed`);
this.layout();
}
@@ -427,8 +433,8 @@ export class AccountDialog extends Modal {
}
private async runAddAccountAction() {
this.logService.debug(`Adding account - providers ${JSON.stringify(Iterable.consume(this._providerViewsMap.keys()))}`);
const vals = Iterable.consume(this._providerViewsMap.values())[0];
let pickedValue: string | undefined;
if (vals.length === 0) {
this._notificationService.error(localize('accountDialog.noCloudsRegistered', "You have no clouds enabled. Go to Settings -> Search Azure Account Configuration -> Enable at least one cloud"));