ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 02:48:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Enable strictNullChecks for extensions by default (#19197)

Browse Source 
* Strict null on extensions

* fix test

* Fail on no stdin
This commit is contained in:
Charles Gagnon
2022-04-25 09:19:42 -07:00
committed by GitHub
parent d0aae8e95b
commit cd8a747522
17 changed files with 39 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
extensions/admin-tool-ext-win/src/main.ts
View File

@@ -82,6 +82,7 @@ async function handleLaunchSsmsMinGswDialogCommand(connectionContext?: azdata.Ob
if (!connectionContext) {
TelemetryReporter.sendErrorEvent(TelemetryViews.SsmsMinGsw, 'NoConnectionContext');
void vscode.window.showErrorMessage(localize('adminToolExtWin.noConnectionContextForGsw', "No ConnectionContext provided for handleLaunchSsmsMinPropertiesDialogCommand"));
return;
}
return launchSsmsDialog(
@@ -101,7 +102,7 @@ async function launchSsmsDialog(action: string, connectionContext: azdata.Object
return;
}
let oeNode: azdata.objectexplorer.ObjectExplorerNode;
let oeNode: azdata.objectexplorer.ObjectExplorerNode | undefined;
// Server node is a Connection node and so doesn't have the NodeInfo
if (connectionContext.isConnectionNode) {
oeNode = undefined;
@@ -153,11 +154,11 @@ async function launchSsmsDialog(action: string, connectionContext: azdata.Object
// Process has exited so remove from map of running processes
runningProcesses.delete(proc.pid);
const err = stderr.toString();
if ((execException && execException.code !== 0) || err !== '') {
if ((execException?.code !== 0) || err !== '') {
TelemetryReporter.sendErrorEvent(
TelemetryViews.SsmsMinDialog,
'LaunchSsmsDialogError',
execException ? execException.code.toString() : '',
execException ? execException?.code?.toString() : '',
getTelemetryErrorType(err));
}
@@ -170,7 +171,7 @@ async function launchSsmsDialog(action: string, connectionContext: azdata.Object
// If we're not using AAD the tool prompts for a password on stdin
if (params.useAad !== true) {
proc.stdin.end(password ? password : '');
proc.stdin!.end(password ? password : '');
}
// Save the process into our map so we can make sure to stop them if we exit before shutting down