ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-25 17:23:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

table designer perf improvement - add user setting for preload db model (#20608)

Browse Source 
* add user setting for preload db model

* vbump sts

* more description
This commit is contained in:
Alan Ren
2022-09-15 14:25:36 -07:00
committed by GitHub
parent 08a9527314
commit cddfc7fd92
5 changed files with 52 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
extensions/mssql/src/tableDesigner/tableDesigner.ts
View File

@@ -10,11 +10,15 @@ import { sqlProviderName } from '../constants';
import { generateUuid } from 'vscode-languageclient/lib/utils/uuid';
import { ITelemetryEventProperties, Telemetry } from '../telemetry';
import * as nls from 'vscode-nls';
import { getConfigPreloadDatabaseModel, setConfigPreloadDatabaseModel } from '../utils';
const localize = nls.loadMessageBundle();
const NewTableText = localize('tableDesigner.NewTable', "New Table");
const DidInformUserKey: string = 'tableDesigner.DidInformUser';
export function registerTableDesignerCommands(appContext: AppContext) {
appContext.extensionContext.subscriptions.push(vscode.commands.registerCommand('mssql.newTable', async (context: azdata.ObjectExplorerContext) => {
void showPreloadDbModelSettingPrompt(appContext);
const connectionString = await azdata.connection.getConnectionString(context.connectionProfile.id, true);
const tableIcon = context.nodeInfo.nodeSubType as azdata.designers.TableIcon;
const telemetryInfo = await getTelemetryInfo(context, tableIcon);
@@ -32,6 +36,7 @@ export function registerTableDesignerCommands(appContext: AppContext) {
}));
appContext.extensionContext.subscriptions.push(vscode.commands.registerCommand('mssql.designTable', async (context: azdata.ObjectExplorerContext) => {
void showPreloadDbModelSettingPrompt(appContext);
const server = context.connectionProfile.serverName;
const database = context.connectionProfile.databaseName;
const schema = context.nodeInfo.metadata.schema;
@@ -62,3 +67,25 @@ async function getTelemetryInfo(context: azdata.ObjectExplorerContext, tableType
telemetryInfo['tableType'] = tableType;
return telemetryInfo;
}
async function showPreloadDbModelSettingPrompt(appContext: AppContext): Promise<void> {
// skip if the setting is already enabled.
if (getConfigPreloadDatabaseModel()) {
return;
}
// only show the prompt once.
const didInformUser = appContext.extensionContext.globalState.get<boolean>(DidInformUserKey);
if (!didInformUser) {
void appContext.extensionContext.globalState.update(DidInformUserKey, true);
} else {
return;
}
const yesOption = localize('tableDesigner.yes', "Yes");
const noOption = localize('tableDesigner.no', "No");
const result = await vscode.window.showInformationMessage(localize('tableDesigner.turnOnPreloadingMessage', "Do you want to reduce the table designer load time by enabling the database model preloading? The database model will be preloaded when you expand the database node in object explorer."), yesOption, noOption);
if (result === yesOption) {
setConfigPreloadDatabaseModel(true);
}
}