Merge from vscode 2c306f762bf9c3db82dc06c7afaa56ef46d72f79 (#14050)

* Merge from vscode 2c306f762bf9c3db82dc06c7afaa56ef46d72f79

* Fix breaks

* Extension management fixes

* Fix breaks in windows bundling

* Fix/skip failing tests

* Update distro

* Add clear to nuget.config

* Add hygiene task

* Bump distro

* Fix hygiene issue

* Add build to hygiene exclusion

* Update distro

* Update hygiene

* Hygiene exclusions

* Update tsconfig

* Bump distro for server breaks

* Update build config

* Update darwin path

* Add done calls to notebook tests

* Skip failing tests

* Disable smoke tests

build/azure-pipelines/product-build.yml

@@ -2,158 +2,201 @@ trigger: none
 pr: none
 
 schedules:
-- cron: "0 5 * * Mon-Fri"
-  displayName: Mon-Fri at 7:00
-  branches:
-    include:
-    - master
+  - cron: "0 5 * * Mon-Fri"
+    displayName: Mon-Fri at 7:00
+    branches:
+      include:
+        - master
 
 resources:
   containers:
-  - container: vscode-x64
-    image: vscodehub.azurecr.io/vscode-linux-build-agent:x64
-    endpoint: VSCodeHub
-  - container: vscode-arm64
-    image: vscodehub.azurecr.io/vscode-linux-build-agent:stretch-arm64
-    endpoint: VSCodeHub
-  - container: vscode-armhf
-    image: vscodehub.azurecr.io/vscode-linux-build-agent:stretch-armhf
-    endpoint: VSCodeHub
-  - container: snapcraft
-    image: snapcore/snapcraft:stable
+    - container: vscode-x64
+      image: vscodehub.azurecr.io/vscode-linux-build-agent:x64
+      endpoint: VSCodeHub
+    - container: vscode-arm64
+      image: vscodehub.azurecr.io/vscode-linux-build-agent:stretch-arm64
+      endpoint: VSCodeHub
+    - container: vscode-armhf
+      image: vscodehub.azurecr.io/vscode-linux-build-agent:stretch-armhf
+      endpoint: VSCodeHub
+    - container: snapcraft
+      image: snapcore/snapcraft:stable
 
 stages:
-- stage: Compile
-  jobs:
-  - job: Compile
-    pool:
-      vmImage: 'Ubuntu-16.04'
-    container: vscode-x64
-    steps:
-    - template: product-compile.yml
+  - stage: Compile
+    jobs:
+      - job: Compile
+        pool:
+          vmImage: "Ubuntu-16.04"
+        container: vscode-x64
+        variables:
+          VSCODE_ARCH: x64
+        steps:
+          - template: product-compile.yml
 
-- stage: Windows
-  dependsOn:
-  - Compile
-  condition: and(succeeded(), eq(variables['VSCODE_COMPILE_ONLY'], 'false'))
-  pool:
-    vmImage: VS2017-Win2016
-  jobs:
-  - job: Windows
-    condition: and(succeeded(), eq(variables['VSCODE_BUILD_WIN32'], 'true'))
-    variables:
-      VSCODE_ARCH: x64
-    steps:
-    - template: win32/product-build-win32.yml
-
-  - job: Windows32
-    condition: and(succeeded(), eq(variables['VSCODE_BUILD_WIN32_32BIT'], 'true'))
-    variables:
-      VSCODE_ARCH: ia32
-    steps:
-    - template: win32/product-build-win32.yml
-
-  - job: WindowsARM64
-    condition: and(succeeded(), eq(variables['VSCODE_BUILD_WIN32_ARM64'], 'true'))
-    variables:
-      VSCODE_ARCH: arm64
-    steps:
-    - template: win32/product-build-win32-arm64.yml
-
-- stage: Linux
-  dependsOn:
-  - Compile
-  condition: and(succeeded(), eq(variables['VSCODE_COMPILE_ONLY'], 'false'))
-  pool:
-    vmImage: 'Ubuntu-16.04'
-  jobs:
-  - job: Linux
-    condition: and(succeeded(), eq(variables['VSCODE_BUILD_LINUX'], 'true'))
-    container: vscode-x64
-    variables:
-      VSCODE_ARCH: x64
-      NPM_ARCH: x64
-    steps:
-    - template: linux/product-build-linux.yml
-
-  - job: LinuxSnap
+  - stage: Windows
     dependsOn:
-    - Linux
-    condition: and(succeeded(), eq(variables['VSCODE_BUILD_LINUX'], 'true'))
-    container: snapcraft
-    variables:
-      VSCODE_ARCH: x64
-    steps:
-    - template: linux/snap-build-linux.yml
+      - Compile
+    condition: and(succeeded(), eq(variables['VSCODE_COMPILE_ONLY'], 'false'))
+    pool:
+      vmImage: VS2017-Win2016
+    jobs:
+      - job: Windows
+        condition: and(succeeded(), eq(variables['VSCODE_BUILD_WIN32'], 'true'))
+        timeoutInMinutes: 90
+        variables:
+          VSCODE_ARCH: x64
+        steps:
+          - template: win32/product-build-win32.yml
 
-  - job: LinuxArmhf
-    condition: and(succeeded(), eq(variables['VSCODE_BUILD_LINUX_ARMHF'], 'true'))
-    container: vscode-armhf
-    variables:
-      VSCODE_ARCH: armhf
-      NPM_ARCH: armv7l
-    steps:
-    - template: linux/product-build-linux.yml
+      - job: Windows32
+        condition: and(succeeded(), eq(variables['VSCODE_BUILD_WIN32_32BIT'], 'true'))
+        timeoutInMinutes: 90
+        variables:
+          VSCODE_ARCH: ia32
+        steps:
+          - template: win32/product-build-win32.yml
 
-  - job: LinuxArm64
-    condition: and(succeeded(), eq(variables['VSCODE_BUILD_LINUX_ARM64'], 'true'))
-    container: vscode-arm64
-    variables:
-      VSCODE_ARCH: arm64
-      NPM_ARCH: arm64
-    steps:
-    - template: linux/product-build-linux.yml
+      - job: WindowsARM64
+        condition: and(succeeded(), eq(variables['VSCODE_BUILD_WIN32_ARM64'], 'true'))
+        timeoutInMinutes: 90
+        variables:
+          VSCODE_ARCH: arm64
+        steps:
+          - template: win32/product-build-win32.yml
 
-  - job: LinuxAlpine
-    condition: and(succeeded(), eq(variables['VSCODE_BUILD_LINUX_ALPINE'], 'true'))
-    variables:
-      VSCODE_ARCH: alpine
-    steps:
-    - template: linux/product-build-linux-multiarch.yml
+  - stage: Linux
+    dependsOn:
+      - Compile
+    condition: and(succeeded(), eq(variables['VSCODE_COMPILE_ONLY'], 'false'))
+    pool:
+      vmImage: "Ubuntu-16.04"
+    jobs:
+      - job: Linux
+        condition: and(succeeded(), eq(variables['VSCODE_BUILD_LINUX'], 'true'))
+        container: vscode-x64
+        variables:
+          VSCODE_ARCH: x64
+          NPM_ARCH: x64
+        steps:
+          - template: linux/product-build-linux.yml
 
-  - job: LinuxWeb
-    condition: and(succeeded(), eq(variables['VSCODE_BUILD_WEB'], 'true'))
-    variables:
-      VSCODE_ARCH: x64
-    steps:
-    - template: web/product-build-web.yml
+      - job: LinuxSnap
+        dependsOn:
+          - Linux
+        condition: and(succeeded(), eq(variables['VSCODE_BUILD_LINUX'], 'true'))
+        container: snapcraft
+        variables:
+          VSCODE_ARCH: x64
+        steps:
+          - template: linux/snap-build-linux.yml
 
-- stage: macOS
-  dependsOn:
-  - Compile
-  condition: and(succeeded(), eq(variables['VSCODE_COMPILE_ONLY'], 'false'))
-  pool:
-    vmImage: macOS-latest
-  jobs:
-  - job: macOS
-    condition: and(succeeded(), eq(variables['VSCODE_BUILD_MACOS'], 'true'))
-    steps:
-    - template: darwin/product-build-darwin.yml
+      - job: LinuxArmhf
+        condition: and(succeeded(), eq(variables['VSCODE_BUILD_LINUX_ARMHF'], 'true'))
+        container: vscode-armhf
+        variables:
+          VSCODE_ARCH: armhf
+          NPM_ARCH: armv7l
+        steps:
+          - template: linux/product-build-linux.yml
 
-- stage: Mooncake
-  dependsOn:
-  - Windows
-  - Linux
-  - macOS
-  condition: and(succeededOrFailed(), eq(variables['VSCODE_COMPILE_ONLY'], 'false'))
-  pool:
-    vmImage: 'Ubuntu-16.04'
-  jobs:
-  - job: SyncMooncake
-    displayName: Sync Mooncake
-    steps:
-    - template: sync-mooncake.yml
+      - job: LinuxSnapArmhf
+        dependsOn:
+          - LinuxArmhf
+        condition: and(succeeded(), eq(variables['VSCODE_BUILD_LINUX_ARMHF'], 'true'))
+        container: snapcraft
+        variables:
+          VSCODE_ARCH: armhf
+        steps:
+          - template: linux/snap-build-linux.yml
 
-- stage: Publish
-  dependsOn:
-  - Windows
-  - Linux
-  - macOS
-  condition: and(succeeded(), eq(variables['VSCODE_COMPILE_ONLY'], 'false'), or(eq(variables['VSCODE_RELEASE'], 'true'), and(or(eq(variables['VSCODE_QUALITY'], 'insider'), eq(variables['VSCODE_QUALITY'], 'exploration')), eq(variables['Build.Reason'], 'Schedule'))))
-  pool:
-    vmImage: 'Ubuntu-16.04'
-  jobs:
-  - job: BuildService
-    displayName: Build Service
-    steps:
-    - template: release.yml
+      - job: LinuxArm64
+        condition: and(succeeded(), eq(variables['VSCODE_BUILD_LINUX_ARM64'], 'true'))
+        container: vscode-arm64
+        variables:
+          VSCODE_ARCH: arm64
+          NPM_ARCH: arm64
+        steps:
+          - template: linux/product-build-linux.yml
+
+      - job: LinuxSnapArm64
+        dependsOn:
+          - LinuxArm64
+        condition: and(succeeded(), eq(variables['VSCODE_BUILD_LINUX_ARM64'], 'true'))
+        container: snapcraft
+        variables:
+          VSCODE_ARCH: arm64
+        steps:
+          - template: linux/snap-build-linux.yml
+
+      - job: LinuxAlpine
+        condition: and(succeeded(), eq(variables['VSCODE_BUILD_LINUX_ALPINE'], 'true'))
+        steps:
+          - template: linux/product-build-alpine.yml
+
+      - job: LinuxWeb
+        condition: and(succeeded(), eq(variables['VSCODE_BUILD_WEB'], 'true'))
+        variables:
+          VSCODE_ARCH: x64
+        steps:
+          - template: web/product-build-web.yml
+
+  - stage: macOS
+    dependsOn:
+      - Compile
+    condition: and(succeeded(), eq(variables['VSCODE_COMPILE_ONLY'], 'false'))
+    pool:
+      vmImage: macOS-latest
+    jobs:
+      - job: macOS
+        condition: and(succeeded(), eq(variables['VSCODE_BUILD_MACOS'], 'true'))
+        timeoutInMinutes: 90
+        variables:
+          VSCODE_ARCH: x64
+        steps:
+          - template: darwin/product-build-darwin.yml
+
+  - stage: macOSARM64
+    dependsOn:
+      - Compile
+    condition: and(succeeded(), eq(variables['VSCODE_COMPILE_ONLY'], 'false'))
+    pool:
+      vmImage: macOS-latest
+    jobs:
+      - job: macOSARM64
+        condition: and(succeeded(), eq(variables['VSCODE_BUILD_MACOS_ARM64'], 'true'))
+        timeoutInMinutes: 90
+        variables:
+          VSCODE_ARCH: arm64
+        steps:
+          - template: darwin/product-build-darwin.yml
+
+  - stage: Mooncake
+    dependsOn:
+      - Windows
+      - Linux
+      - macOS
+      - macOSARM64
+    condition: and(succeededOrFailed(), eq(variables['VSCODE_COMPILE_ONLY'], 'false'))
+    pool:
+      vmImage: "Ubuntu-16.04"
+    jobs:
+      - job: SyncMooncake
+        displayName: Sync Mooncake
+        steps:
+          - template: sync-mooncake.yml
+
+  - stage: Publish
+    dependsOn:
+      - Windows
+      - Linux
+      - macOS
+      - macOSARM64
+    condition: and(succeeded(), eq(variables['VSCODE_COMPILE_ONLY'], 'false'), or(eq(variables['VSCODE_RELEASE'], 'true'), and(or(eq(variables['VSCODE_QUALITY'], 'insider'), eq(variables['VSCODE_QUALITY'], 'exploration')), eq(variables['Build.Reason'], 'Schedule'))))
+    pool:
+      vmImage: "Ubuntu-16.04"
+    jobs:
+      - job: BuildService
+        displayName: Build Service
+        steps:
+          - template: release.yml