Merge from vscode 2c306f762bf9c3db82dc06c7afaa56ef46d72f79 (#14050)

* Merge from vscode 2c306f762bf9c3db82dc06c7afaa56ef46d72f79

* Fix breaks

* Extension management fixes

* Fix breaks in windows bundling

* Fix/skip failing tests

* Update distro

* Add clear to nuget.config

* Add hygiene task

* Bump distro

* Fix hygiene issue

* Add build to hygiene exclusion

* Update distro

* Update hygiene

* Hygiene exclusions

* Update tsconfig

* Bump distro for server breaks

* Update build config

* Update darwin path

* Add done calls to notebook tests

* Skip failing tests

* Disable smoke tests

test/smoke/Audit.md

@@ -1,13 +1,13 @@
 # VS Code Smoke Tests Failures History
 This file contains a history of smoke test failures which could be avoided if particular techniques were used in the test (e.g. binding test elements with HTML5 `data-*` attribute).
 
-To better understand what can be employed in smoke test to ensure its stability, it is important to understand patterns that led to smoke test breakage. This markdown is a result of work on [this issue](https://github.com/Microsoft/vscode/issues/27906).
+To better understand what can be employed in smoke test to ensure its stability, it is important to understand patterns that led to smoke test breakage. This markdown is a result of work on [this issue](https://github.com/microsoft/vscode/issues/27906).
 
 # Log
 1. This following change led to the smoke test failure because DOM element's attribute `a[title]` was changed:
-	[eac49a3](https://github.com/Microsoft/vscode/commit/eac49a321b84cb9828430e9dcd3f34243a3480f7)
+	[eac49a3](https://github.com/microsoft/vscode/commit/eac49a321b84cb9828430e9dcd3f34243a3480f7)
 
 	This attribute was used in the smoke test to grab the contents of SCM part in status bar:
-	[0aec2d6](https://github.com/Microsoft/vscode/commit/0aec2d6838b5e65cc74c33b853ffbd9fa191d636)
+	[0aec2d6](https://github.com/microsoft/vscode/commit/0aec2d6838b5e65cc74c33b853ffbd9fa191d636)
 
-2. To be continued...
+2. To be continued...

test/smoke/README.md

@@ -5,6 +5,9 @@ Make sure you are on **Node v12.x**.
 ### Run
 
 ```bash
+# Build extensions in repo (if needed)
+yarn && yarn compile
+
 # Install Dependencies and Compile
 yarn --cwd test/smoke
 
@@ -30,6 +33,7 @@ You must always run the smoketest version which matches the release you are test
 
 ```bash
 git checkout release/1.22
+yarn && yarn compile
 yarn --cwd test/smoke
 ```
 

test/smoke/src/areas/extensions/extensions.test.ts

@@ -17,7 +17,7 @@ export function setup() {
 
 			await app.workbench.extensions.openExtensionsViewlet();
 
-			await app.workbench.extensions.installExtension('michelkaporin.vscode-smoketest-check');
+			await app.workbench.extensions.installExtension('michelkaporin.vscode-smoketest-check', true);
 
 			await app.workbench.extensions.waitForExtensionsViewlet();
 

test/smoke/src/areas/languages/languages.test.ts

@@ -34,10 +34,9 @@ export function setup() {
 
 			await app.code.waitForElement(Problems.getSelectorInEditor(ProblemSeverity.ERROR));
 
-			const problems = new Problems(app.code);
-			await problems.showProblemsView();
+			await app.workbench.problems.showProblemsView();
 			await app.code.waitForElement(Problems.getSelectorInProblemsView(ProblemSeverity.ERROR));
-			await problems.hideProblemsView();
+			await app.workbench.problems.hideProblemsView();
 		});
 	});
 }

test/smoke/src/areas/multiroot/multiroot.test.ts

@@ -40,7 +40,7 @@ export function setup() {
 
 			// restart with preventing additional windows from restoring
 			// to ensure the window after restart is the multi-root workspace
-			await app.restart({ workspaceOrFolder: workspaceFilePath, extraArgs: ['--disable-restore-windows'] });
+			await app.restart({ workspaceOrFolder: workspaceFilePath });
 		});
 
 		it('shows results from all folders', async function () {

test/smoke/src/areas/notebook/notebook.test.ts

@@ -48,7 +48,7 @@ export function setup() {
 			const app = this.app as Application;
 			await app.workbench.notebook.openNotebook();
 			await app.workbench.notebook.insertNotebookCell('code');
-			await app.workbench.notebook.waitForActiveCellEditorContents(' ');
+			await app.workbench.notebook.waitForActiveCellEditorContents('');
 			await app.workbench.notebook.stopEditingCell();
 			await app.workbench.notebook.deleteActiveCell();
 			await app.workbench.notebook.waitForMarkdownContents('p', 'Markdown Cell');
@@ -67,7 +67,7 @@ export function setup() {
 			const app = this.app as Application;
 			await app.workbench.notebook.openNotebook();
 			await app.workbench.notebook.insertNotebookCell('code');
-			await app.workbench.notebook.executeCellAction('.notebook-editor .monaco-list-row.focused div.monaco-toolbar .codicon-debug');
+			await app.workbench.notebook.executeCellAction('.notebook-editor .monaco-list-row.focused div.monaco-toolbar .codicon-notebook-execute');
 			await app.workbench.notebook.waitForActiveCellEditorContents('test');
 		});
 	});

test/smoke/src/areas/workbench/localization.test.ts

@@ -15,7 +15,7 @@ export function setup() {
 			}
 
 			await app.workbench.extensions.openExtensionsViewlet();
-			await app.workbench.extensions.installExtension('ms-ceintl.vscode-language-pack-de');
+			await app.workbench.extensions.installExtension('ms-ceintl.vscode-language-pack-de', false);
 
 			await app.restart({ extraArgs: ['--locale=DE'] });
 		});