ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Notebooks: Add Tooltips for Link/Image Buttons on Markdown Toolbar (#17763)

Browse Source 
* Add title for tooltips

* Tweak tooltips
This commit is contained in:
Chris LaFreniere
2021-11-30 12:40:06 -08:00
committed by GitHub
parent 1f9a6a611b
commit ce7935e7d2
1 changed files with 22 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
src/sql/workbench/contrib/notebook/browser/cellViews/markdownToolbar.component.ts
View File

@@ -66,23 +66,21 @@ export class MarkdownToolbarComponent extends AngularDisposable {
public previewFeaturesEnabled: boolean = false; public previewFeaturesEnabled: boolean = false;
public buttonBold = localize('buttonBold', "Bold"); public bold = localize('bold', "Bold");
public buttonItalic = localize('buttonItalic', "Italic"); public italic = localize('italic', "Italic");
public buttonUnderline = localize('buttonUnderline', "Underline"); public underline = localize('underline', "Underline");
public buttonHighlight = localize('buttonHighlight', "Highlight"); public highlight = localize('highlight', "Highlight");
public buttonCode = localize('buttonCode', "Code"); public insertCode = localize('insertCode', "Insert code");
public buttonLink = localize('buttonLink', "Link"); public insertLink = localize('insertLink', "Insert link");
public buttonList = localize('buttonList', "List"); public insertList = localize('insertList', "Insert list");
public buttonOrderedList = localize('buttonOrderedList', "Ordered list"); public insertOrderedList = localize('insertOrderedList', "Insert ordered list");
public buttonImage = localize('buttonImage', "Image"); public insertImage = localize('insertImage', "Insert image");
public buttonPreview = localize('buttonPreview', "Markdown preview toggle - off"); public buttonPreview = localize('buttonPreview', "Markdown preview toggle - off");
public dropdownHeading = localize('dropdownHeading', "Heading"); public dropdownHeading = localize('dropdownHeading', "Heading");
public optionHeading1 = localize('optionHeading1', "Heading 1"); public optionHeading1 = localize('optionHeading1', "Heading 1");
public optionHeading2 = localize('optionHeading2', "Heading 2"); public optionHeading2 = localize('optionHeading2', "Heading 2");
public optionHeading3 = localize('optionHeading3', "Heading 3"); public optionHeading3 = localize('optionHeading3', "Heading 3");
public optionParagraph = localize('optionParagraph', "Paragraph"); public optionParagraph = localize('optionParagraph', "Paragraph");
public insertLinkHeading = localize('callout.insertLinkHeading', "Insert link");
public insertImageHeading = localize('callout.insertImageHeading', "Insert image");
public richTextViewButton = localize('richTextViewButton', "Rich Text View"); public richTextViewButton = localize('richTextViewButton', "Rich Text View");
public splitViewButton = localize('splitViewButton', "Split View"); public splitViewButton = localize('splitViewButton', "Split View");
@@ -130,6 +128,7 @@ export class MarkdownToolbarComponent extends AngularDisposable {
linkButtonContainer = DOM.$('li.action-item'); linkButtonContainer = DOM.$('li.action-item');
linkButtonContainer.setAttribute('role', 'presentation'); linkButtonContainer.setAttribute('role', 'presentation');
let linkButton = new Button(linkButtonContainer); let linkButton = new Button(linkButtonContainer);
linkButton.title = this.insertLink;
linkButton.element.setAttribute('class', 'action-label codicon insert-link masked-icon'); linkButton.element.setAttribute('class', 'action-label codicon insert-link masked-icon');
let buttonStyle: IButtonStyles = { let buttonStyle: IButtonStyles = {
buttonBackground: null buttonBackground: null
@@ -143,6 +142,7 @@ export class MarkdownToolbarComponent extends AngularDisposable {
imageButtonContainer = DOM.$('li.action-item'); imageButtonContainer = DOM.$('li.action-item');
imageButtonContainer.setAttribute('role', 'presentation'); imageButtonContainer.setAttribute('role', 'presentation');
let imageButton = new Button(imageButtonContainer); let imageButton = new Button(imageButtonContainer);
imageButton.title = this.insertImage;
imageButton.element.setAttribute('class', 'action-label codicon insert-image masked-icon'); imageButton.element.setAttribute('class', 'action-label codicon insert-image masked-icon');
imageButton.style(buttonStyle); imageButton.style(buttonStyle);
@@ -151,17 +151,17 @@ export class MarkdownToolbarComponent extends AngularDisposable {
await this.onInsertButtonClick(e, MarkdownButtonType.IMAGE_PREVIEW); await this.onInsertButtonClick(e, MarkdownButtonType.IMAGE_PREVIEW);
})); }));
} else { } else {
linkButton = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.linkText', '', 'insert-link masked-icon', this.buttonLink, this.cellModel, MarkdownButtonType.LINK); linkButton = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.linkText', '', 'insert-link masked-icon', this.insertLink, this.cellModel, MarkdownButtonType.LINK);
imageButton = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.imageText', '', 'insert-image masked-icon', this.buttonImage, this.cellModel, MarkdownButtonType.IMAGE); imageButton = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.imageText', '', 'insert-image masked-icon', this.insertImage, this.cellModel, MarkdownButtonType.IMAGE);
} }
let boldButton = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.boldText', '', 'bold masked-icon', this.buttonBold, this.cellModel, MarkdownButtonType.BOLD); let boldButton = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.boldText', '', 'bold masked-icon', this.bold, this.cellModel, MarkdownButtonType.BOLD);
let italicButton = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.italicText', '', 'italic masked-icon', this.buttonItalic, this.cellModel, MarkdownButtonType.ITALIC); let italicButton = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.italicText', '', 'italic masked-icon', this.italic, this.cellModel, MarkdownButtonType.ITALIC);
let underlineButton = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.underlineText', '', 'underline masked-icon', this.buttonUnderline, this.cellModel, MarkdownButtonType.UNDERLINE); let underlineButton = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.underlineText', '', 'underline masked-icon', this.underline, this.cellModel, MarkdownButtonType.UNDERLINE);
let highlightButton = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.highlightText', '', 'highlight masked-icon', this.buttonHighlight, this.cellModel, MarkdownButtonType.HIGHLIGHT); let highlightButton = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.highlightText', '', 'highlight masked-icon', this.highlight, this.cellModel, MarkdownButtonType.HIGHLIGHT);
let codeButton = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.codeText', '', 'code masked-icon', this.buttonCode, this.cellModel, MarkdownButtonType.CODE); let codeButton = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.codeText', '', 'code masked-icon', this.insertCode, this.cellModel, MarkdownButtonType.CODE);
let listButton = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.listText', '', 'list masked-icon', this.buttonList, this.cellModel, MarkdownButtonType.UNORDERED_LIST); let listButton = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.listText', '', 'list masked-icon', this.insertList, this.cellModel, MarkdownButtonType.UNORDERED_LIST);
let orderedListButton = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.orderedText', '', 'ordered-list masked-icon', this.buttonOrderedList, this.cellModel, MarkdownButtonType.ORDERED_LIST); let orderedListButton = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.orderedText', '', 'ordered-list masked-icon', this.insertOrderedList, this.cellModel, MarkdownButtonType.ORDERED_LIST);
let headingDropdown = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.heading', '', 'heading', this.dropdownHeading, this.cellModel, null); let headingDropdown = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.heading', '', 'heading', this.dropdownHeading, this.cellModel, null);
let heading1 = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.heading1', this.optionHeading1, 'heading 1', this.optionHeading1, this.cellModel, MarkdownButtonType.HEADING1); let heading1 = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.heading1', this.optionHeading1, 'heading 1', this.optionHeading1, this.cellModel, MarkdownButtonType.HEADING1);
let heading2 = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.heading2', this.optionHeading2, 'heading 2', this.optionHeading2, this.cellModel, MarkdownButtonType.HEADING2); let heading2 = this._instantiationService.createInstance(TransformMarkdownAction, 'notebook.heading2', this.optionHeading2, 'heading 2', this.optionHeading2, this.cellModel, MarkdownButtonType.HEADING2);
@@ -356,11 +356,11 @@ export class MarkdownToolbarComponent extends AngularDisposable {
if (type === MarkdownButtonType.LINK_PREVIEW) { if (type === MarkdownButtonType.LINK_PREVIEW) {
const defaultLabel = this.getCurrentLinkLabel(); const defaultLabel = this.getCurrentLinkLabel();
const defaultLinkUrl = this.getCurrentLinkUrl(); const defaultLinkUrl = this.getCurrentLinkUrl();
this._linkCallout = this._instantiationService.createInstance(LinkCalloutDialog, this.insertLinkHeading, dialogPosition, dialogProperties, defaultLabel, defaultLinkUrl); this._linkCallout = this._instantiationService.createInstance(LinkCalloutDialog, this.insertLink, dialogPosition, dialogProperties, defaultLabel, defaultLinkUrl);
this._linkCallout.render(); this._linkCallout.render();
calloutOptions = await this._linkCallout.open(); calloutOptions = await this._linkCallout.open();
} else if (type === MarkdownButtonType.IMAGE_PREVIEW) { } else if (type === MarkdownButtonType.IMAGE_PREVIEW) {
const imageCallout = this._instantiationService.createInstance(ImageCalloutDialog, this.insertImageHeading, dialogPosition, dialogProperties); const imageCallout = this._instantiationService.createInstance(ImageCalloutDialog, this.insertImage, dialogPosition, dialogProperties);
imageCallout.render(); imageCallout.render();
calloutOptions = await imageCallout.open(); calloutOptions = await imageCallout.open();
} }