ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-19 01:25:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Strict null pass on some base ui files (#4832)

Browse Source 
* more strict null checks in base browser code

* revert changes to radiobutton

* fix some more minor things, enable strict null check in pipelines

* formatting

* fix compile errors

* make null undefined

* more null to undefined
This commit is contained in:
Anthony Dresser
2019-04-03 16:18:33 -07:00
committed by GitHub
parent 80a8e1a4da
commit cef5bbb2be
25 changed files with 253 additions and 234 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/sql/base/browser/ui/radioButton/radioButton.ts
View File

@@ -3,13 +3,9 @@
* Licensed under the Source EULA. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
'use strict';
import * as DOM from 'vs/base/browser/dom';
import { IContextViewProvider } from 'vs/base/browser/ui/contextview/contextview';
import { Color } from 'vs/base/common/color';
import { InputBox } from 'vs/base/browser/ui/inputbox/inputBox';
import { Event, Emitter } from 'vs/base/common/event';
import { Widget } from 'vs/base/browser/ui/widget';
import { withNullAsUndefined } from 'vs/base/common/types';
export interface IRadioButtonOptions {
label: string;
@@ -43,20 +39,24 @@ export class RadioButton extends Widget {
container.appendChild(this._label);
}
public set name(value: string) {
this.inputElement.setAttribute('name', value);
public set name(value: string | undefined) {
if (value) {
this.inputElement.setAttribute('name', value);
}
}
public get name(): string {
return this.inputElement.getAttribute('name');
public get name(): string | undefined {
return withNullAsUndefined(this.inputElement.getAttribute('name'));
}
public set value(value: string) {
this.inputElement.setAttribute('value', value);
public set value(value: string | undefined) {
if (value) {
this.inputElement.setAttribute('value', value);
}
}
public get value(): string {
return this.inputElement.getAttribute('value');
public get value(): string | undefined {
return withNullAsUndefined(this.inputElement.getAttribute('value'));
}
public set checked(val: boolean) {
@@ -83,4 +83,4 @@ export class RadioButton extends Widget {
this._label.innerText = val;
}
}
}