ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Update return types that can return undefined (#14660)

Browse Source
This commit is contained in:
Charles Gagnon
2021-03-11 10:09:50 -08:00
committed by GitHub
parent 6c877a4e20
commit cf862854c5
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/sql/platform/connection/common/connectionManagement.ts
View File

@@ -161,13 +161,13 @@ export interface IConnectionManagementService {
deleteConnectionGroup(group: ConnectionProfileGroup): Promise<boolean>; deleteConnectionGroup(group: ConnectionProfileGroup): Promise<boolean>;
getAdvancedProperties(): azdata.ConnectionOption[]; getAdvancedProperties(): azdata.ConnectionOption[] | undefined;
getConnectionUri(connectionProfile: IConnectionProfile): string; getConnectionUri(connectionProfile: IConnectionProfile): string;
getFormattedUri(uri: string, connectionProfile: IConnectionProfile): string; getFormattedUri(uri: string, connectionProfile: IConnectionProfile): string;
getConnectionUriFromId(connectionId: string): string; getConnectionUriFromId(connectionId: string): string | undefined;
isConnected(fileUri: string): boolean; isConnected(fileUri: string): boolean;
@@ -193,7 +193,7 @@ export interface IConnectionManagementService {
addSavedPassword(connectionProfile: IConnectionProfile): Promise<IConnectionProfile>; addSavedPassword(connectionProfile: IConnectionProfile): Promise<IConnectionProfile>;
listDatabases(connectionUri: string): Thenable<azdata.ListDatabasesResult>; listDatabases(connectionUri: string): Thenable<azdata.ListDatabasesResult | undefined>;
/** /**
* Register a connection provider * Register a connection provider
@@ -204,11 +204,11 @@ export interface IConnectionManagementService {
editGroup(group: ConnectionProfileGroup): Promise<void>; editGroup(group: ConnectionProfileGroup): Promise<void>;
getConnectionProfile(fileUri: string): IConnectionProfile; getConnectionProfile(fileUri: string): IConnectionProfile | undefined;
getConnectionInfo(fileUri: string): ConnectionManagementInfo; getConnectionInfo(fileUri: string): ConnectionManagementInfo | undefined;
getDefaultProviderId(): string; getDefaultProviderId(): string | undefined;
getUniqueConnectionProvidersByNameMap(providerNameToDisplayNameMap: { [providerDisplayName: string]: string }): { [providerDisplayName: string]: string }; getUniqueConnectionProvidersByNameMap(providerNameToDisplayNameMap: { [providerDisplayName: string]: string }): { [providerDisplayName: string]: string };

4
src/sql/workbench/services/connection/browser/connectionManagementService.ts
View File

@@ -1218,11 +1218,11 @@ export class ConnectionManagementService extends Disposable implements IConnecti
return this._connectionStatusManager.isConnecting(fileUri); return this._connectionStatusManager.isConnecting(fileUri);
} }
public getConnectionProfile(fileUri: string): interfaces.IConnectionProfile { public getConnectionProfile(fileUri: string): interfaces.IConnectionProfile | undefined {
return this._connectionStatusManager.isConnected(fileUri) ? this._connectionStatusManager.getConnectionProfile(fileUri) : undefined; return this._connectionStatusManager.isConnected(fileUri) ? this._connectionStatusManager.getConnectionProfile(fileUri) : undefined;
} }
public getConnectionInfo(fileUri: string): ConnectionManagementInfo { public getConnectionInfo(fileUri: string): ConnectionManagementInfo | undefined {
return this._connectionStatusManager.isConnected(fileUri) ? this._connectionStatusManager.findConnection(fileUri) : undefined; return this._connectionStatusManager.isConnected(fileUri) ? this._connectionStatusManager.findConnection(fileUri) : undefined;
} }