From d08182416bc7c1869eef181eb4eaf8d059dc9c7d Mon Sep 17 00:00:00 2001 From: brian-harris <61598682+brian-harris@users.noreply.github.com> Date: Fri, 18 Jun 2021 12:22:41 -0700 Subject: [PATCH] add feedback button, open report issue dialog (#15762) --- extensions/sql-migration/images/sendFeedback.svg | 3 +++ extensions/sql-migration/package.json | 10 +++++++++- extensions/sql-migration/package.nls.json | 3 ++- .../sql-migration/src/constants/iconPathHelper.ts | 5 +++++ extensions/sql-migration/src/constants/strings.ts | 1 + extensions/sql-migration/src/main.ts | 10 +++++++++- 6 files changed, 29 insertions(+), 3 deletions(-) create mode 100644 extensions/sql-migration/images/sendFeedback.svg diff --git a/extensions/sql-migration/images/sendFeedback.svg b/extensions/sql-migration/images/sendFeedback.svg new file mode 100644 index 0000000000..92b2ab23d0 --- /dev/null +++ b/extensions/sql-migration/images/sendFeedback.svg @@ -0,0 +1,3 @@ + + + diff --git a/extensions/sql-migration/package.json b/extensions/sql-migration/package.json index 1aebca2769..303a4697d8 100644 --- a/extensions/sql-migration/package.json +++ b/extensions/sql-migration/package.json @@ -15,6 +15,7 @@ "activationEvents": [ "onDashboardOpen", "onCommand:sqlmigration.start", + "onCommand:sqlmigration.sendfeedback", "onCommand:sqlmigration.openNotebooks" ], "main": "./out/main", @@ -33,6 +34,12 @@ "category": "%migration-command-category%", "icon": "./images/migration.svg" }, + { + "command": "sqlmigration.sendfeedback", + "title": "%send-feedback-command%", + "category": "%migration-command-category%", + "icon": "./images/sendFeedback.svg" + }, { "command": "sqlmigration.openNotebooks", "title": "%migration-notebook-command-title%", @@ -58,7 +65,8 @@ "col": 0, "widget": { "tasks-widget": [ - "sqlmigration.start" + "sqlmigration.start", + "sqlmigration.sendfeedback" ] } }, diff --git a/extensions/sql-migration/package.nls.json b/extensions/sql-migration/package.nls.json index 55203c2c4a..e29db19b83 100644 --- a/extensions/sql-migration/package.nls.json +++ b/extensions/sql-migration/package.nls.json @@ -5,5 +5,6 @@ "migration-dashboard-title": "Azure SQL Migration", "migration-dashboard-tasks": "Migration Tasks", "migration-command-category": "Azure SQL Migration", - "start-migration-command": "Migrate to Azure SQL" + "start-migration-command": "Migrate to Azure SQL", + "send-feedback-command": "Feedback" } diff --git a/extensions/sql-migration/src/constants/iconPathHelper.ts b/extensions/sql-migration/src/constants/iconPathHelper.ts index 53cd081cdd..2f5899cb0c 100644 --- a/extensions/sql-migration/src/constants/iconPathHelper.ts +++ b/extensions/sql-migration/src/constants/iconPathHelper.ts @@ -33,6 +33,7 @@ export class IconPathHelper { public static error: IconPath; public static completingCutover: IconPath; public static migrationService: IconPath; + public static sendFeedback: IconPath; public static setExtensionContext(context: vscode.ExtensionContext) { IconPathHelper.copy = { @@ -123,5 +124,9 @@ export class IconPathHelper { light: context.asAbsolutePath('images/migrationService.svg'), dark: context.asAbsolutePath('images/migrationService.svg') }; + IconPathHelper.sendFeedback = { + light: context.asAbsolutePath('images/sendFeedback.svg'), + dark: context.asAbsolutePath('images/sendFeedback.svg') + }; } } diff --git a/extensions/sql-migration/src/constants/strings.ts b/extensions/sql-migration/src/constants/strings.ts index b6eda86617..0e9bfe3053 100644 --- a/extensions/sql-migration/src/constants/strings.ts +++ b/extensions/sql-migration/src/constants/strings.ts @@ -296,6 +296,7 @@ export function MIGRATION_INPROGRESS_WARNING(count: number) { return localize('sql.migration.inprogress.warning.multiple', "{0} databases have warnings", count); } } +export const FEEDBACK_ISSUE_TITLE = localize('sql.migration.feedback.issue.title', "Feedback on the migration experience"); // Azure APIs export const EASTUS2EUAP = localize('sql.migration.eastus2euap', 'East US 2 EUAP'); diff --git a/extensions/sql-migration/src/main.ts b/extensions/sql-migration/src/main.ts index d32ee11ed2..ae57d2eb9f 100644 --- a/extensions/sql-migration/src/main.ts +++ b/extensions/sql-migration/src/main.ts @@ -56,7 +56,15 @@ class SQLMigration { }), azdata.tasks.registerTask('sqlmigration.start', async () => { await this.launchMigrationWizard(); - }) + }), + azdata.tasks.registerTask('sqlmigration.sendfeedback', async () => { + const actionId = 'workbench.action.openIssueReporter'; + const args = { + extensionId: 'microsoft.sql-migration', + issueTitle: loc.FEEDBACK_ISSUE_TITLE, + }; + return await vscode.commands.executeCommand(actionId, args); + }), ]; this.context.subscriptions.push(...commandDisposables);