ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-16 09:35:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix SDK style projects not being able to find system dacpacs (#18218)

Browse Source 
* fix SDK style projects not being able to find system dacpacs

* fix tests
This commit is contained in:
Kim Santiago
2022-02-16 09:36:01 -08:00
committed by GitHub
parent 89cc59a2fd
commit d24a289af5
7 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/sql-database-projects/src/tools/buildHelper.ts
View File

@@ -83,8 +83,12 @@ export class BuildHelper {
public constructBuildArguments(projectPath: string, buildDirPath: string, isSdkStyleProject: boolean): string {
projectPath = utils.getQuotedPath(projectPath);
buildDirPath = utils.getQuotedPath(buildDirPath);
// Right now SystemDacpacsLocation and NETCoreTargetsPath get set to the same thing, but separating them out for if we move
// the system dacpacs somewhere else and also so that the variable name makes more sense if building from the commandline,
// since SDK style projects don't to specify the targets path, just where the system dacpacs are
if (isSdkStyleProject) {
return ` build ${projectPath} /p:NetCoreBuild=true`;
return ` build ${projectPath} /p:NetCoreBuild=true /p:SystemDacpacsLocation=${buildDirPath}`;
} else {
return ` build ${projectPath} /p:NetCoreBuild=true /p:NETCoreTargetsPath=${buildDirPath}`;
}