ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Addresses accessiblility bug by converting editable dropdowns to normal when in accessible mode (#7159)

Browse Source 
* Automatically disabling editability on extension dropdowns when in accessible mode

* correcting variable name type
This commit is contained in:
Benjin Dubishar
2019-09-12 11:08:05 -07:00
committed by GitHub
parent aaf115a5c8
commit d262ea21e3
2 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/schema-compare/src/dialogs/schemaCompareDialog.ts
View File

@@ -60,7 +60,7 @@ export class SchemaCompareDialog {
private targetIsDacpac: boolean;
private connectionId: string;
private sourceDbEditable: string;
private taregtDbEditable: string;
private targetDbEditable: string;
private previousSource: mssql.SchemaCompareEndpointInfo;
private previousTarget: mssql.SchemaCompareEndpointInfo;
@@ -455,7 +455,7 @@ export class SchemaCompareDialog {
let sourcefilled = (this.sourceIsDacpac && this.existsDacpac(this.sourceTextBox.value))
|| (!this.sourceIsDacpac && !isNullOrUndefined(this.sourceDatabaseDropdown.value) && this.sourceDatabaseDropdown.values.findIndex(x => this.matchesValue(x, this.sourceDbEditable)) !== -1);
let targetfilled = (this.targetIsDacpac && this.existsDacpac(this.targetTextBox.value))
|| (!this.targetIsDacpac && !isNullOrUndefined(this.targetDatabaseDropdown.value) && this.targetDatabaseDropdown.values.findIndex(x => this.matchesValue(x, this.taregtDbEditable)) !== -1);
|| (!this.targetIsDacpac && !isNullOrUndefined(this.targetDatabaseDropdown.value) && this.targetDatabaseDropdown.values.findIndex(x => this.matchesValue(x, this.targetDbEditable)) !== -1);
return sourcefilled && targetfilled;
}
@@ -616,7 +616,7 @@ export class SchemaCompareDialog {
}
).component();
this.targetDatabaseDropdown.onValueChanged((value) => {
this.taregtDbEditable = value;
this.targetDbEditable = value;
this.dialog.okButton.enabled = this.shouldEnableOkayButton();
});