ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-21 01:25:37 -05:00
Code Issues Packages Projects Releases Wiki Activity

Clean up dialog event hide reasons (#14566)

Browse Source 
* Clean up dialog event hide reasons

* Remove done
This commit is contained in:
Charles Gagnon
2021-03-05 08:54:35 -08:00
committed by GitHub
parent 21019f7452
commit d2faf9075d
21 changed files with 67 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/workbench/contrib/backup/browser/backupDialog.ts
View File

@@ -82,7 +82,7 @@ export class BackupDialog extends Modal {
* Clean up the module and DOM element and close the dialog
*/
public close() {
this.hide();
this.hide('close');
}
public dispose(): void {

2
src/sql/workbench/contrib/charts/browser/configureChartDialog.ts
View File

@@ -52,6 +52,6 @@ export class ConfigureChartDialog extends Modal {
}
public close() {
this.hide();
this.hide('close');
}
}

2
src/sql/workbench/contrib/notebook/browser/calloutDialog/imageCalloutDialog.ts
View File

@@ -184,7 +184,7 @@ export class ImageCalloutDialog extends CalloutDialog<IImageCalloutDialogOptions
}
public insert(): void {
this.hide();
this.hide('ok');
this._selectionComplete.resolve({
insertEscapedMarkdown: `![](${escapeUrl(this._imageUrlInputBox.value)})`,
imagePath: this._imageUrlInputBox.value,

2
src/sql/workbench/contrib/notebook/browser/calloutDialog/linkCalloutDialog.ts
View File

@@ -144,7 +144,7 @@ export class LinkCalloutDialog extends CalloutDialog<ILinkCalloutDialogOptions>
}
public insert(): void {
this.hide();
this.hide('ok');
let escapedLabel = escapeLabel(this._linkTextInputBox.value);
let escapedUrl = escapeUrl(this._linkUrlInputBox.value);

8
src/sql/workbench/contrib/webview/browser/webViewDialog.ts
View File

@@ -4,7 +4,7 @@
*--------------------------------------------------------------------------------------------*/
import { Button } from 'sql/base/browser/ui/button/button';
import { Modal } from 'sql/workbench/browser/modal/modal';
import { HideReason, Modal } from 'sql/workbench/browser/modal/modal';
import * as TelemetryKeys from 'sql/platform/telemetry/common/telemetryKeys';
import { IThemeService } from 'vs/platform/theme/common/themeService';
import { Event, Emitter } from 'vs/base/common/event';
@@ -136,11 +136,11 @@ export class WebViewDialog extends Modal {
public ok(): void {
this._onOk.fire();
this.close();
this.close('ok');
}
public close() {
this.hide();
public close(hideReason: HideReason = 'close') {
this.hide(hideReason);
this._onClosed.fire();
}