ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-24 01:25:37 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix BDC remember password and reprompting connection (#7957)

Browse Source 
* Fix remember password and reprompting connection

* comment

* Fix to remember password for session

* Fix floating promises
This commit is contained in:
Charles Gagnon
2019-10-29 07:27:31 -07:00
committed by GitHub
parent 789ee4b133
commit d315ccff68
8 changed files with 183 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
extensions/big-data-cluster/src/bigDataCluster/tree/controllerTreeNode.ts
View File

@@ -103,7 +103,15 @@ export class ControllerRootNode extends ControllerTreeNode {
return this.children as ControllerNode[];
}
public addControllerNode(
/**
* Creates or updates a node in the tree with the specified connection information
* @param url The URL for the BDC management endpoint
* @param auth The type of auth to use
* @param username The username (if basic auth)
* @param password The password (if basic auth)
* @param rememberPassword Whether to store the password in the password store when saving
*/
public addOrUpdateControllerNode(
url: string,
auth: AuthType,
username: string,
@@ -201,6 +209,10 @@ export class ControllerNode extends ControllerTreeNode {
this._password = pw;
}
public set label(label: string) {
super.label = label || this.generateLabel();
}
public get rememberPassword() {
return this._rememberPassword;
}
@@ -209,10 +221,6 @@ export class ControllerNode extends ControllerTreeNode {
this._rememberPassword = rememberPassword;
}
public set label(label: string) {
super.label = label || this.generateLabel();
}
private generateLabel(): string {
let label = `controller: ${ControllerNode.toIpAndPort(this._url)}`;
if (this._auth === 'basic') {