ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-13 17:22:15 -05:00
Code Issues Packages Projects Releases Wiki Activity

Implement use strict linting (#7223)

Browse Source 
* implement use strict linting

* commit changes

* add additional check for strict
This commit is contained in:
Anthony Dresser
2019-09-16 17:36:31 -07:00
committed by GitHub
parent 603a79d094
commit d3ea9c3168
4 changed files with 62 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
build/gulpfile.hygiene.js
View File

@@ -189,20 +189,10 @@ const tslintBaseFilter = [
'!extensions/vscode-api-tests/testWorkspace2/**',
'!extensions/**/*.test.ts',
'!extensions/html-language-features/server/lib/jquery.d.ts',
// {{SQL CARBON EDIT}}
'!extensions/big-data-cluster/src/bigDataCluster/controller/apiGenerated.ts'
'!extensions/big-data-cluster/src/bigDataCluster/controller/apiGenerated.ts' // {{SQL CARBON EDIT}}
];
// {{SQL CARBON EDIT}}
// const useStrictFilter = [
// 'src/**'
// ];
const sqlFilter = [
'src/sql/**'
];
// {{SQL CARBON EDIT}}
const sqlFilter = ['src/sql/**']; // {{SQL CARBON EDIT}}
const tslintCoreFilter = [
'src/**/*.ts',
@@ -336,23 +326,6 @@ function hygiene(some) {
this.emit('data', file);
});
// {{SQL CARBON EDIT}}
// Check for unnecessary 'use strict' lines. These are automatically added by the alwaysStrict compiler option so don't need to be added manually
// const useStrict = es.through(function (file) {
// const lines = file.__lines;
// // Only take the first 10 lines to reduce false positives- the compiler will throw an error if it's not the first non-comment line in a file
// // (10 is used to account for copyright and extraneous newlines)
// lines.slice(0, 10).forEach((line, i) => {
// if (/\s*'use\s*strict\s*'/.test(line)) {
// console.error(file.relative + '(' + (i + 1) + ',1): Unnecessary \'use strict\' - this is already added by the compiler');
// errorCount++;
// }
// });
// this.emit('data', file);
// });
// {{SQL CARBON EDIT}} END
const formatting = es.map(function (file, cb) {
tsfmt.processString(file.path, file.contents.toString('utf8'), {
verify: false,