Another code layering (#4037)

* working on formatting

* fixed basic lint errors; starting moving things to their appropriate location

* formatting

* update tslint to match the version of vscode we have

* remove unused code

* work in progress fixing layering

* formatting

* moved connection management service to platform

* formatting

* add missing file

* moving more servies

* formatting

* moving more services

* formatting

* wip

* moving more services

* formatting

* move css file

* add missing svgs

* moved the rest of services

* formatting

* changing around some references

* formatting

* revert tslint

* revert some changes that brake things

* formatting

* fix tests

* fix testzx

* fix tests

* fix tests

* fix compile issue

src/sql/platform/connection/common/connectionManagement.ts

@@ -279,29 +279,6 @@ export interface IConnectionManagementService {
 	getConnectionProfileById(profileId: string): IConnectionProfile;
 }
 
-export const IConnectionDialogService = createDecorator<IConnectionDialogService>('connectionDialogService');
-export interface IConnectionDialogService {
-	_serviceBrand: any;
-	/**
-	 * Opens the connection dialog and returns the promise for successfully opening the dialog
-	 * @param connectionManagementService
-	 * @param params
-	 * @param model
-	 * @param connectionResult
-	 */
-	showDialog(connectionManagementService: IConnectionManagementService, params: INewConnectionParams, model: IConnectionProfile, connectionResult?: IConnectionResult): Thenable<void>;
-
-	/**
-	 * Opens the connection dialog and returns the promise when connection is made
-	 * or dialog is closed
-	 * @param connectionManagementService
-	 * @param params
-	 * @param model
-	 * @param connectionResult
-	 */
-	openDialogAndWait(connectionManagementService: IConnectionManagementService, params?: INewConnectionParams, model?: IConnectionProfile, connectionResult?: IConnectionResult): Thenable<IConnectionProfile>;
-}
-
 export enum RunQueryOnConnectionMode {
 	none = 0,
 	executeQuery = 1,