Addressed comments left in a merged PR (#17307)

This commit is contained in:
Leila Lali
2021-10-11 09:07:12 -07:00
committed by GitHub
parent 479bd10d02
commit d479c96658
3 changed files with 7 additions and 11 deletions

View File

@@ -238,7 +238,7 @@ export class DeployService {
providerName: 'MSSQL',
saveProfile: false,
id: '',
connectionName: `${profile.profileName}`,
connectionName: profile.profileName,
options: [],
authenticationType: 'SqlLogin'
};
@@ -401,13 +401,9 @@ RUN ["/bin/bash", "/opt/commands/start.sh"]
await fse.writeFile(filePath, content);
}
private async getCurrentIds(commandToRun: string): Promise<string[]> {
const currentIds = await utils.executeCommand(commandToRun, this._outputChannel);
return currentIds ? currentIds.split(/\r?\n/) : [];
}
public async getCurrentDockerContainer(imageLabel: string): Promise<string[]> {
return await this.getCurrentIds(`docker ps -q -a --filter label=${imageLabel}`);
const currentIds = await utils.executeCommand(`docker ps -q -a --filter label=${imageLabel}`, this._outputChannel);
return currentIds ? currentIds.split(/\r?\n/) : [];
}
public async cleanDockerObjects(ids: string[], commandsToClean: string[]): Promise<void> {