mirror of
https://github.com/ckaczor/azuredatastudio.git
synced 2026-02-16 10:58:30 -05:00
Schema Compare cleanup (#11418)
* cleanup async and await stuff * remove awaits * remove more awaits
This commit is contained in:
@@ -24,9 +24,10 @@ const mocktarget: string = 'target.dacpac';
|
||||
let mockExtensionContext: TypeMoq.IMock<vscode.ExtensionContext>;
|
||||
let testContext: TestContext;
|
||||
|
||||
before(async function (): Promise<void> {
|
||||
before(function (): void {
|
||||
testContext = createContext();
|
||||
});
|
||||
|
||||
describe('SchemaCompareDialog.openDialog', function (): void {
|
||||
before(() => {
|
||||
mockExtensionContext = TypeMoq.Mock.ofType<vscode.ExtensionContext>();
|
||||
@@ -57,8 +58,8 @@ describe('SchemaCompareMainWindow.start', function (): void {
|
||||
|
||||
should(result.getComparisonResult() === undefined);
|
||||
|
||||
result.sourceEndpointInfo = await setDacpacEndpointInfo(mocksource);
|
||||
result.targetEndpointInfo = await setDacpacEndpointInfo(mocktarget);
|
||||
result.sourceEndpointInfo = setDacpacEndpointInfo(mocksource);
|
||||
result.targetEndpointInfo = setDacpacEndpointInfo(mocktarget);
|
||||
await result.execute();
|
||||
|
||||
should(result.getComparisonResult() !== undefined);
|
||||
@@ -109,7 +110,7 @@ describe('SchemaCompareMainWindow.execute', function (): void {
|
||||
testContext = createContext();
|
||||
});
|
||||
|
||||
beforeEach(async function (): Promise<void> {
|
||||
beforeEach(function (): void {
|
||||
testContext.apiWrapper.reset();
|
||||
});
|
||||
|
||||
@@ -123,8 +124,8 @@ describe('SchemaCompareMainWindow.execute', function (): void {
|
||||
|
||||
should(result.getComparisonResult() === undefined);
|
||||
|
||||
result.sourceEndpointInfo = await setDacpacEndpointInfo(mocksource);
|
||||
result.targetEndpointInfo = await setDacpacEndpointInfo(mocktarget);
|
||||
result.sourceEndpointInfo = setDacpacEndpointInfo(mocksource);
|
||||
result.targetEndpointInfo = setDacpacEndpointInfo(mocktarget);
|
||||
|
||||
await shouldThrowSpecificError(async () => await result.execute(), loc.compareErrorMessage('Test failure'));
|
||||
});
|
||||
@@ -139,8 +140,8 @@ describe('SchemaCompareMainWindow.execute', function (): void {
|
||||
|
||||
should(result.getComparisonResult() === undefined);
|
||||
|
||||
result.sourceEndpointInfo = await setDacpacEndpointInfo(mocksource);
|
||||
result.targetEndpointInfo = await setDacpacEndpointInfo(mocktarget);
|
||||
result.sourceEndpointInfo = setDacpacEndpointInfo(mocksource);
|
||||
result.targetEndpointInfo = setDacpacEndpointInfo(mocktarget);
|
||||
|
||||
await result.execute();
|
||||
testContext.apiWrapper.verify(x => x.showErrorMessage(TypeMoq.It.isAny()), TypeMoq.Times.once());
|
||||
@@ -155,8 +156,8 @@ describe('SchemaCompareMainWindow.execute', function (): void {
|
||||
|
||||
should(result.getComparisonResult() === undefined);
|
||||
|
||||
result.sourceEndpointInfo = await setDacpacEndpointInfo(mocksource);
|
||||
result.targetEndpointInfo = await setDacpacEndpointInfo(mocktarget);
|
||||
result.sourceEndpointInfo = setDacpacEndpointInfo(mocksource);
|
||||
result.targetEndpointInfo = setDacpacEndpointInfo(mocktarget);
|
||||
|
||||
await result.execute();
|
||||
|
||||
@@ -176,8 +177,8 @@ describe('SchemaCompareMainWindow.execute', function (): void {
|
||||
|
||||
should(result.getComparisonResult() === undefined);
|
||||
|
||||
result.sourceEndpointInfo = await setDacpacEndpointInfo(mocksource);
|
||||
result.targetEndpointInfo = await setDatabaseEndpointInfo();
|
||||
result.sourceEndpointInfo = setDacpacEndpointInfo(mocksource);
|
||||
result.targetEndpointInfo = setDatabaseEndpointInfo();
|
||||
|
||||
await result.execute();
|
||||
|
||||
@@ -229,7 +230,7 @@ describe('SchemaCompareMainWindow.updateSourceAndTarget', function (): void {
|
||||
should(result.getComparisonResult() === undefined);
|
||||
|
||||
result.sourceEndpointInfo = {...endpointInfo};
|
||||
result.targetEndpointInfo = await setDacpacEndpointInfo(mocktarget);
|
||||
result.targetEndpointInfo = setDacpacEndpointInfo(mocktarget);
|
||||
|
||||
result.updateSourceAndTarget();
|
||||
|
||||
@@ -249,8 +250,8 @@ describe('SchemaCompareMainWindow.updateSourceAndTarget', function (): void {
|
||||
|
||||
should(result.getComparisonResult() === undefined);
|
||||
|
||||
result.sourceEndpointInfo = await setDacpacEndpointInfo(mocksource);
|
||||
result.targetEndpointInfo = await setDacpacEndpointInfo(mocktarget);
|
||||
result.sourceEndpointInfo = setDacpacEndpointInfo(mocksource);
|
||||
result.targetEndpointInfo = setDacpacEndpointInfo(mocktarget);
|
||||
|
||||
result.updateSourceAndTarget();
|
||||
|
||||
|
||||
Reference in New Issue
Block a user