From d63b741666e3cf0238976f71936e4c5f5f4d6907 Mon Sep 17 00:00:00 2001
From: Kevin Cunnane <kcunnane@microsoft.com>
Date: Thu, 18 Jul 2019 14:02:55 -0700
Subject: [PATCH] Fix markdown in Jupyter books not working (#6420)

Issue here is that for some reason click in tree causes 2 events:
- Selection Changed
- Resource Opened
Due to this, we get the markdown event 2 times and this misbehaves.
I am not confident in changing markdown so implemented similar pattern:
- Throttle requests if they're for the same resource inside 300ms
- This means 2nd event is ignored

Testing:
- Manual, clicked a bunch of markdowns
- It "just works" for me now
---
 extensions/notebook/src/book/bookTreeView.ts | 35 ++++++++++++++++----
 1 file changed, 29 insertions(+), 6 deletions(-)

diff --git a/extensions/notebook/src/book/bookTreeView.ts b/extensions/notebook/src/book/bookTreeView.ts
index 95d4b7050f..3637c87c5f 100644
--- a/extensions/notebook/src/book/bookTreeView.ts
+++ b/extensions/notebook/src/book/bookTreeView.ts
@@ -21,6 +21,8 @@ export class BookTreeViewProvider implements vscode.TreeDataProvider<BookTreeIte
 	private _tableOfContentsPath: string[];
 	private _allNotebooks = new Map<string, BookTreeItem>();
 	private _extensionContext: vscode.ExtensionContext;
+	private _throttleTimer: any;
+	private _resource: string;
 
 	constructor(private workspaceRoot: string, extensionContext: vscode.ExtensionContext) {
 		if (workspaceRoot !== '') {
@@ -57,12 +59,33 @@ export class BookTreeViewProvider implements vscode.TreeDataProvider<BookTreeIte
 	}
 
 	openMarkdown(resource: string): void {
-		try {
-			vscode.commands.executeCommand('markdown.showPreview', vscode.Uri.file(resource));
-		} catch (e) {
-			vscode.window.showErrorMessage(localize('openMarkdownError', 'Open file {0} failed: {1}',
-				resource,
-				e instanceof Error ? e.message : e));
+		this.runThrottledAction(resource, () => {
+			try {
+				vscode.commands.executeCommand('markdown.showPreview', vscode.Uri.file(resource));
+			} catch (e) {
+				vscode.window.showErrorMessage(localize('openMarkdownError', "Open file {0} failed: {1}",
+					resource,
+					e instanceof Error ? e.message : e));
+			}
+		});
+	}
+
+	private runThrottledAction(resource: string, action: () => void) {
+		const isResourceChange = resource !== this._resource;
+		if (isResourceChange) {
+			clearTimeout(this._throttleTimer);
+			this._throttleTimer = undefined;
+		}
+
+		this._resource = resource;
+
+		// Schedule update if none is pending
+		if (!this._throttleTimer) {
+			if (isResourceChange) {
+				action();
+			} else {
+				this._throttleTimer = setTimeout(() => action(), 300);
+			}
 		}
 	}