From d74e5e64573704da02aa57fda881ed3892c9233c Mon Sep 17 00:00:00 2001 From: Kevin Cunnane Date: Tue, 5 Feb 2019 21:21:59 -0800 Subject: [PATCH] Fix regression where border line between editor and output was lost (#3915) --- src/sql/parts/notebook/notebookStyles.ts | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/sql/parts/notebook/notebookStyles.ts b/src/sql/parts/notebook/notebookStyles.ts index a73c3b2ce2..5d42fe0ffb 100644 --- a/src/sql/parts/notebook/notebookStyles.ts +++ b/src/sql/parts/notebook/notebookStyles.ts @@ -109,8 +109,18 @@ export function registerNotebookThemes(overrideEditorThemeSetting: boolean): IDi } `); + // Ensure there's always a line between editor and output + collector.addRule(` + .notebookEditor .notebook-cell.active code-component { + border-color: ${inactiveBorder}; + border-width: 0px 0px 1px 0px; + border-style: solid; + border-radius: 0; + } + `); + if (addBorderToInactiveCodeCells) { - // Sets a border for the editor component if we don't have a custom color for editor instead + // Sets a border for the editor component if we don't have a custom line color for editor instead collector.addRule(` .notebookEditor .notebook-cell code-component { border-color: ${inactiveBorder}; @@ -118,10 +128,6 @@ export function registerNotebookThemes(overrideEditorThemeSetting: boolean): IDi border-style: solid; border-radius: 3px 3px 3px 3px; } - .notebookEditor .notebook-cell.active code-component { - border-width: 0px 0px 1px 0px; - border-radius: 0px; - } .notebookEditor .notebook-cell:hover code-component { border-width: 0px 0px 1px 0px; border-radius: 0px;