ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Handle unsupported providers when launching from command line (#20793)

Browse Source
This commit is contained in:
Charles Gagnon
2022-10-10 13:04:53 -07:00
committed by GitHub
parent 93008b51c4
commit d76ccab65c
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/sql/workbench/contrib/commandLine/electron-browser/commandLine.ts
View File

@@ -128,6 +128,16 @@ export class CommandLineWorkbenchContribution implements IWorkbenchContribution,
} }
let connectedContext: azdata.ConnectedContext = undefined; let connectedContext: azdata.ConnectedContext = undefined;
if (profile) { if (profile) {
if (profile.providerName && !this._capabilitiesService.providers[profile.providerName]) {
const installed = await this._connectionManagementService.handleUnsupportedProvider(profile.providerName);
if (!installed) {
// User cancelled install prompt so exit early since we won't be able to connect
return;
}
// Recreate the profile here now that we have our provider registered so that we get the correct
// option names. See https://github.com/microsoft/azuredatastudio/issues/20773 for details about the issue
profile = this.readProfileFromArgs(args);
}
if (this._notificationService) { if (this._notificationService) {
this._notificationService.status(localize('connectingLabel', "Connecting: {0}", profile.serverName), { hideAfter: 2500 }); this._notificationService.status(localize('connectingLabel', "Connecting: {0}", profile.serverName), { hideAfter: 2500 });
} }
@@ -138,7 +148,7 @@ export class CommandLineWorkbenchContribution implements IWorkbenchContribution,
let updatedProfile = this._connectionManagementService.getConnectionProfileById(profile.id); let updatedProfile = this._connectionManagementService.getConnectionProfileById(profile.id);
connectedContext = { connectionProfile: new ConnectionProfile(this._capabilitiesService, updatedProfile).toIConnectionProfile() }; connectedContext = { connectionProfile: new ConnectionProfile(this._capabilitiesService, updatedProfile).toIConnectionProfile() };
} catch (err) { } catch (err) {
this.logService.warn('Failed to connect due to error' + getErrorMessage(err)); this.logService.warn('Failed to connect due to error: ' + getErrorMessage(err));
} }
} }
if (commandName) { if (commandName) {