ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix for: https://github.com/Microsoft/sqlopsstudio/issues/1317 (#2228)

Browse Source 
use culture invariant display value for number conversion
This commit is contained in:
Alan Ren
2018-08-14 13:57:22 -07:00
committed by GitHub
parent b17b4ce880
commit d9134d6085
3 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/parts/dashboard/widgets/insights/insightsWidget.component.ts
View File

@@ -231,7 +231,7 @@ export class InsightsWidget extends DashboardWidget implements IDashboardWidget,
if (componentInstance.setConfig) { if (componentInstance.setConfig) {
componentInstance.setConfig(this.insightConfig.type[this._typeKey]); componentInstance.setConfig(this.insightConfig.type[this._typeKey]);
} }
componentInstance.data = { columns: result.columnInfo.map(item => item.columnName), rows: result.rows.map(row => row.map(item => item.displayValue)) }; componentInstance.data = { columns: result.columnInfo.map(item => item.columnName), rows: result.rows.map(row => row.map(item => (item.invariantCultureDisplayValue === null || item.invariantCultureDisplayValue === undefined) ? item.displayValue : item.invariantCultureDisplayValue)) };
if (componentInstance.init) { if (componentInstance.init) {
componentInstance.init(); componentInstance.init();

2
src/sql/parts/grid/views/query/chartViewer.component.ts
View File

@@ -329,7 +329,7 @@ export class ChartViewerComponent implements OnInit, OnDestroy, IChartViewAction
this._executeResult = <IInsightData>{}; this._executeResult = <IInsightData>{};
this._executeResult.columns = dataSet.columnDefinitions.map(def => def.name); this._executeResult.columns = dataSet.columnDefinitions.map(def => def.name);
this._executeResult.rows = dataSet.dataRows.getRange(0, dataSet.dataRows.getLength()).map(gridRow => { this._executeResult.rows = dataSet.dataRows.getRange(0, dataSet.dataRows.getLength()).map(gridRow => {
return gridRow.values.map(cell => cell.displayValue); return gridRow.values.map(cell => (cell.invariantCultureDisplayValue === null || cell.invariantCultureDisplayValue === undefined) ? cell.displayValue : cell.invariantCultureDisplayValue);
}); });
} }

1
src/sql/sqlops.d.ts vendored
View File

@@ -816,6 +816,7 @@ declare module 'sqlops' {
export interface DbCellValue { export interface DbCellValue {
displayValue: string; displayValue: string;
isNull: boolean; isNull: boolean;
invariantCultureDisplayValue: string;
} }
export interface ResultSetSubset { export interface ResultSetSubset {