Agent - Accessibility Bugs (WIP) (#5807)

* fix accessbility issue where tabbing would get wrong focus

* dialogs open one at a time

* get focus on filter headers

* added tool tips to proxy dialog

* added labels to step dialog
This commit is contained in:
Aditya Bist
2019-06-07 09:41:00 -07:00
committed by GitHub
parent cbaa0a132f
commit d9b48bae80
6 changed files with 65 additions and 20 deletions

View File

@@ -147,12 +147,14 @@ export class JobStepDialog extends AgentDialog<JobStepData> {
this.openButton = view.modelBuilder.button()
.withProperties({
label: this.OpenCommandText,
title: this.OpenCommandText,
width: '80px',
isFile: true
}).component();
this.parseButton = view.modelBuilder.button()
.withProperties({
label: this.ParseCommandText,
title: this.ParseCommandText,
width: '80px',
isFile: false
}).component();
@@ -176,7 +178,9 @@ export class JobStepDialog extends AgentDialog<JobStepData> {
height: 300,
width: 400,
multiline: true,
inputType: 'text'
inputType: 'text',
ariaLabel: this.CommandLabelString,
placeHolder: this.CommandLabelString
})
.component();
}
@@ -185,6 +189,8 @@ export class JobStepDialog extends AgentDialog<JobStepData> {
this.generalTab.registerContent(async (view) => {
this.nameTextBox = view.modelBuilder.inputBox()
.withProperties({
ariaLabel: this.StepNameLabelString,
placeHolder: this.StepNameLabelString
}).component();
this.nameTextBox.required = true;
this.nameTextBox.onTextChanged(() => {
@@ -214,6 +220,8 @@ export class JobStepDialog extends AgentDialog<JobStepData> {
this.processExitCodeBox = view.modelBuilder.inputBox()
.withProperties({
ariaLabel: this.ProcessExitCodeText,
placeHolder: this.ProcessExitCodeText
}).component();
this.processExitCodeBox.enabled = false;