ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-21 01:25:37 -05:00
Code Issues Packages Projects Releases Wiki Activity

Agent - Accessibility Bugs (WIP) (#5807)

Browse Source 
* fix accessbility issue where tabbing would get wrong focus

* dialogs open one at a time

* get focus on filter headers

* added tool tips to proxy dialog

* added labels to step dialog
This commit is contained in:
Aditya Bist
2019-06-07 09:41:00 -07:00
committed by GitHub
parent cbaa0a132f
commit d9b48bae80
6 changed files with 65 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/base/browser/ui/panel/panel.ts
View File

@@ -82,6 +82,7 @@ export class TabbedPanel extends Disposable {
this.header = DOM.$('.composite.title');
this.tabList = DOM.$('.tabList');
this.tabList.setAttribute('role', 'tablist');
this.tabList.setAttribute('tabindex', '0');
this.tabList.style.height = this.headersize + 'px';
this.header.appendChild(this.tabList);
let actionbarcontainer = DOM.$('.title-actions');
@@ -95,7 +96,6 @@ export class TabbedPanel extends Disposable {
}
this.body = DOM.$('.tabBody');
this.body.setAttribute('role', 'tabpanel');
this.body.setAttribute('tabindex', '0');
this.parent.appendChild(this.body);
}

7
src/sql/base/browser/ui/table/plugins/headerFilter.plugin.ts
View File

@@ -74,11 +74,16 @@ export class HeaderFilter<T extends Slick.SlickData> {
if (column.id === '_detail_selector') {
return;
}
const $el = jQuery('<div></div>')
const $el = jQuery('<div tabIndex="0"></div>')
.addClass('slick-header-menubutton')
.data('column', column);
$el.bind('click', (e) => this.showFilter(e)).appendTo(args.node);
$el.bind('keydown', (e) => {
if (e.key === 'Enter' || e.keyCode === 13) {
this.showFilter(e);
}
}).appendTo(args.node);
}
private handleBeforeHeaderCellDestroy(e: Event, args: Slick.OnBeforeHeaderCellDestroyEventArgs<T>) {