From db5a0a892ad10c0619a4953e499bb52cad9c06f0 Mon Sep 17 00:00:00 2001 From: Anthony Dresser Date: Thu, 23 May 2019 16:07:28 -0700 Subject: [PATCH] fix issue with empty connection (#5602) --- src/sql/platform/connection/common/connectionProfile.ts | 2 +- src/sqltest/parts/connection/connectionProfile.test.ts | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/sql/platform/connection/common/connectionProfile.ts b/src/sql/platform/connection/common/connectionProfile.ts index d98847b192..0b9c6ac906 100644 --- a/src/sql/platform/connection/common/connectionProfile.ts +++ b/src/sql/platform/connection/common/connectionProfile.ts @@ -43,7 +43,7 @@ export class ConnectionProfile extends ProviderConnectionInfo implements interfa this.saveProfile = model.saveProfile; this._id = model.id; this.azureTenantId = model.azureTenantId; - if (this.capabilitiesService) { + if (this.capabilitiesService && model.providerName) { const options = this.capabilitiesService.getCapabilities(model.providerName).connection.connectionOptions; let appNameOption = options.find(option => option.specialValueType === ConnectionOptionSpecialType.appName); if (appNameOption) { diff --git a/src/sqltest/parts/connection/connectionProfile.test.ts b/src/sqltest/parts/connection/connectionProfile.test.ts index 887c5eff31..b63c443770 100644 --- a/src/sqltest/parts/connection/connectionProfile.test.ts +++ b/src/sqltest/parts/connection/connectionProfile.test.ts @@ -214,4 +214,8 @@ suite('SQL ConnectionProfileInfo tests', () => { assert.notEqual(newProfile.id, conn.id); assert.equal(newProfile.databaseName, 'new db'); }); -}); \ No newline at end of file + + test('an empty connection profile does not cause issues', () => { + assert.doesNotThrow(() => new ConnectionProfile(capabilitiesService, {} as IConnectionProfile)); + }); +});