ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-14 09:59:47 -05:00
Code Issues Packages Projects Releases Wiki Activity

Make publish to docker settings properties required (#19898)

Browse Source 
* Make publish to docker settings properties required

* move
This commit is contained in:
Charles Gagnon
2022-06-30 16:21:53 -07:00
committed by GitHub
parent 9fbd3b3864
commit dc006be73e
5 changed files with 35 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
extensions/sql-database-projects/src/dialogs/deployDatabaseQuickpick.ts
View File

@@ -278,7 +278,6 @@ export async function launchCreateAzureServerQuickPick(project: Project, azureSq
export async function getPublishToDockerSettings(project: ISqlProject): Promise<IPublishToDockerSettings | undefined> {
const target = project.getProjectTargetVersion();
const name = uiUtils.getPublishServerName(target);
let localDbSetting: IDockerSettings | undefined;
// Deploy to docker selected
let portNumber = await vscode.window.showInputBox({
title: constants.enterPortNumber(name),
@@ -370,7 +369,7 @@ export async function getPublishToDockerSettings(project: ISqlProject): Promise<
imageName = `${imageName}:${imageTag.label}`;
}
localDbSetting = {
const dockerSettings: IDockerSettings = {
serverName: constants.defaultLocalServerName,
userName: constants.defaultLocalServerAdminName,
dbName: project.projectFileName,
@@ -388,13 +387,13 @@ export async function getPublishToDockerSettings(project: ISqlProject): Promise<
}
// Server name should be set to localhost
deploySettings.serverName = localDbSetting.serverName;
deploySettings.serverName = dockerSettings.serverName;
// Get the database name from deploy settings
localDbSetting.dbName = deploySettings.databaseName;
dockerSettings.dbName = deploySettings.databaseName;
return {
dockerSettings: localDbSetting,
dockerSettings,
sqlProjectPublishSettings: deploySettings,
};
}