From dcf17cc08b7a74173c7bf6e934a2f232d3a839ed Mon Sep 17 00:00:00 2001 From: Charles Gagnon Date: Wed, 3 Feb 2021 12:16:50 -0800 Subject: [PATCH] Remove async keyword from abstract functions (#14150) --- extensions/agent/src/dialogs/agentDialog.ts | 4 ++-- extensions/arc/src/ui/components/dashboard.ts | 2 +- .../azurecore/src/account-provider/auths/azureAuth.ts | 2 +- .../big-data-cluster/src/bigDataCluster/tree/treeNode.ts | 2 +- .../resource-deployment/src/ui/resourceTypeModel.ts | 2 +- extensions/sql-assessment/src/tabs/sqlAssessmentTab.ts | 2 +- .../assessmentResults/model/assessmentDialogComponent.ts | 2 +- .../sql-migration/src/models/migrationWizardPage.ts | 8 ++++---- 8 files changed, 12 insertions(+), 12 deletions(-) diff --git a/extensions/agent/src/dialogs/agentDialog.ts b/extensions/agent/src/dialogs/agentDialog.ts index b6b17f7b73..2539d7cb86 100644 --- a/extensions/agent/src/dialogs/agentDialog.ts +++ b/extensions/agent/src/dialogs/agentDialog.ts @@ -30,9 +30,9 @@ export abstract class AgentDialog { return this.model.dialogMode; } - protected abstract async updateModel(): Promise; + protected abstract updateModel(): Promise; - protected abstract async initializeDialog(dialog: azdata.window.Dialog): Promise; + protected abstract initializeDialog(dialog: azdata.window.Dialog): Promise; public async openDialog(dialogName?: string) { if (!this._isOpen) { diff --git a/extensions/arc/src/ui/components/dashboard.ts b/extensions/arc/src/ui/components/dashboard.ts index 4284b5dbf3..389752f2f4 100644 --- a/extensions/arc/src/ui/components/dashboard.ts +++ b/extensions/arc/src/ui/components/dashboard.ts @@ -24,5 +24,5 @@ export abstract class Dashboard { return dashboard; } - protected abstract async registerTabs(modelView: azdata.ModelView): Promise<(azdata.DashboardTab | azdata.DashboardTabGroup)[]>; + protected abstract registerTabs(modelView: azdata.ModelView): Promise<(azdata.DashboardTab | azdata.DashboardTabGroup)[]>; } diff --git a/extensions/azurecore/src/account-provider/auths/azureAuth.ts b/extensions/azurecore/src/account-provider/auths/azureAuth.ts index 3b82745571..6c007451f3 100644 --- a/extensions/azurecore/src/account-provider/auths/azureAuth.ts +++ b/extensions/azurecore/src/account-provider/auths/azureAuth.ts @@ -214,7 +214,7 @@ export abstract class AzureAuth implements vscode.Disposable { - protected abstract async login(tenant: Tenant, resource: Resource): Promise<{ response: OAuthTokenResponse, authComplete: Deferred }>; + protected abstract login(tenant: Tenant, resource: Resource): Promise<{ response: OAuthTokenResponse, authComplete: Deferred }>; /** * Refreshes a token, if a refreshToken is passed in then we use that. If it is not passed in then we will prompt the user for consent. diff --git a/extensions/big-data-cluster/src/bigDataCluster/tree/treeNode.ts b/extensions/big-data-cluster/src/bigDataCluster/tree/treeNode.ts index f10c15297e..5fdccdc65e 100644 --- a/extensions/big-data-cluster/src/bigDataCluster/tree/treeNode.ts +++ b/extensions/big-data-cluster/src/bigDataCluster/tree/treeNode.ts @@ -187,7 +187,7 @@ export abstract class TreeNode { } } - public abstract async getChildren(): Promise; + public abstract getChildren(): Promise; public abstract getTreeItem(): vscode.TreeItem; public abstract getNodeInfo(): azdata.NodeInfo; } diff --git a/extensions/resource-deployment/src/ui/resourceTypeModel.ts b/extensions/resource-deployment/src/ui/resourceTypeModel.ts index 1f66b72646..159aff9376 100644 --- a/extensions/resource-deployment/src/ui/resourceTypeModel.ts +++ b/extensions/resource-deployment/src/ui/resourceTypeModel.ts @@ -14,7 +14,7 @@ export abstract class ResourceTypeModel extends Model { } abstract initialize(): void; - abstract async onOk(): Promise; + abstract onOk(): Promise; abstract onCancel(): void; /** * performs the script generation and returns true if script was generated successfully diff --git a/extensions/sql-assessment/src/tabs/sqlAssessmentTab.ts b/extensions/sql-assessment/src/tabs/sqlAssessmentTab.ts index 13190a97c9..d14cc62659 100644 --- a/extensions/sql-assessment/src/tabs/sqlAssessmentTab.ts +++ b/extensions/sql-assessment/src/tabs/sqlAssessmentTab.ts @@ -29,7 +29,7 @@ export abstract class SqlAssessmentTab implements azdata.Tab, vscode.Disposable return this; } - abstract async tabContent(view: azdata.ModelView): Promise; + abstract tabContent(view: azdata.ModelView): Promise; } diff --git a/extensions/sql-migration/src/dialog/assessmentResults/model/assessmentDialogComponent.ts b/extensions/sql-migration/src/dialog/assessmentResults/model/assessmentDialogComponent.ts index a1e9878519..ba6caa142a 100644 --- a/extensions/sql-migration/src/dialog/assessmentResults/model/assessmentDialogComponent.ts +++ b/extensions/sql-migration/src/dialog/assessmentResults/model/assessmentDialogComponent.ts @@ -7,5 +7,5 @@ import * as azdata from 'azdata'; export abstract class AssessmentDialogComponent { - abstract async createComponent(view: azdata.ModelView): Promise; + abstract createComponent(view: azdata.ModelView): Promise; } diff --git a/extensions/sql-migration/src/models/migrationWizardPage.ts b/extensions/sql-migration/src/models/migrationWizardPage.ts index fbbf9f4308..041cdc11f0 100644 --- a/extensions/sql-migration/src/models/migrationWizardPage.ts +++ b/extensions/sql-migration/src/models/migrationWizardPage.ts @@ -27,14 +27,14 @@ export abstract class MigrationWizardPage { }); } - protected abstract async registerContent(view: azdata.ModelView): Promise; + protected abstract registerContent(view: azdata.ModelView): Promise; public getwizardPage(): azdata.window.WizardPage { return this.wizardPage; } - public abstract async onPageEnter(): Promise; - public abstract async onPageLeave(): Promise; + public abstract onPageEnter(): Promise; + public abstract onPageLeave(): Promise; private readonly stateChanges: (() => Promise)[] = []; protected async onStateChangeEvent(e: StateChangeEvent) { @@ -66,7 +66,7 @@ export abstract class MigrationWizardPage { this.queueActive = false; } - protected abstract async handleStateChange(e: StateChangeEvent): Promise; + protected abstract handleStateChange(e: StateChangeEvent): Promise; public canEnter(): Promise { return Promise.resolve(true);