Add Preview tags to object management context menu entries (#23499)

This commit is contained in:
Cory Rivera
2023-06-28 10:03:04 -07:00
committed by GitHub
parent 3acbe2445b
commit dd0bc9d0f3
4 changed files with 24 additions and 20 deletions

View File

@@ -497,6 +497,10 @@
{ {
"command": "mssql.renameObject", "command": "mssql.renameObject",
"when": "false" "when": "false"
},
{
"command": "mssql.detachDatabase",
"when": "false"
} }
], ],
"objectExplorer/item/context": [ "objectExplorer/item/context": [
@@ -519,38 +523,38 @@
{ {
"command": "mssql.newObject", "command": "mssql.newObject",
"when": "connectionProvider == MSSQL && nodeType == Folder && objectType =~ /^(ServerLevelLogins|Users|ServerLevelServerRoles|ApplicationRoles|DatabaseRoles|Databases)$/ && config.workbench.enablePreviewFeatures", "when": "connectionProvider == MSSQL && nodeType == Folder && objectType =~ /^(ServerLevelLogins|Users|ServerLevelServerRoles|ApplicationRoles|DatabaseRoles|Databases)$/ && config.workbench.enablePreviewFeatures",
"group": "0_query@1" "group": "1_objectManagement"
}, },
{ {
"command": "mssql.objectProperties", "command": "mssql.objectProperties",
"when": "connectionProvider == MSSQL && nodeType =~ /^(ServerLevelLogin|User|ServerLevelServerRole|ApplicationRole|DatabaseRole)$/ && config.workbench.enablePreviewFeatures", "when": "connectionProvider == MSSQL && nodeType =~ /^(ServerLevelLogin|User|ServerLevelServerRole|ApplicationRole|DatabaseRole)$/ && config.workbench.enablePreviewFeatures",
"group": "0_query@1", "group": "z_objectManagement",
"isDefault": true "isDefault": true
}, },
{ {
"command": "mssql.objectProperties", "command": "mssql.objectProperties",
"when": "connectionProvider == MSSQL && serverInfo && !isCloud && nodeType && nodeType =~ /^(Database|Server)$/ && mssql:engineedition != 11 && isDevelopment", "when": "connectionProvider == MSSQL && serverInfo && !isCloud && nodeType && nodeType =~ /^(Database|Server)$/ && mssql:engineedition != 11 && isDevelopment",
"group": "0_query@1" "group": "z_objectManagement"
}, },
{ {
"command": "mssql.deleteObject", "command": "mssql.deleteObject",
"when": "connectionProvider == MSSQL && nodeType =~ /^(ServerLevelLogin|User|ServerLevelServerRole|ApplicationRole|DatabaseRole|Database)$/ && config.workbench.enablePreviewFeatures", "when": "connectionProvider == MSSQL && nodeType =~ /^(ServerLevelLogin|User|ServerLevelServerRole|ApplicationRole|DatabaseRole|Database)$/ && config.workbench.enablePreviewFeatures",
"group": "0_query@2" "group": "1_objectManagement"
}, },
{ {
"command": "mssql.renameObject", "command": "mssql.renameObject",
"when": "connectionProvider == MSSQL && nodeType =~ /^(ServerLevelLogin|User|Table|View|ServerLevelServerRole|ApplicationRole|DatabaseRole)$/ && config.workbench.enablePreviewFeatures", "when": "connectionProvider == MSSQL && nodeType =~ /^(ServerLevelLogin|User|Table|View|ServerLevelServerRole|ApplicationRole|DatabaseRole)$/ && config.workbench.enablePreviewFeatures",
"group": "0_query@3" "group": "1_objectManagement"
}, },
{ {
"command": "mssql.renameObject", "command": "mssql.renameObject",
"when": "connectionProvider == MSSQL && nodeType == Column && config.workbench.enablePreviewFeatures && nodePath =~ /^.*\\/Tables\\/.*\\/Columns\\/.*$/", "when": "connectionProvider == MSSQL && nodeType == Column && config.workbench.enablePreviewFeatures && nodePath =~ /^.*\\/Tables\\/.*\\/Columns\\/.*$/",
"group": "0_query@3" "group": "1_objectManagement"
}, },
{ {
"command": "mssql.detachDatabase", "command": "mssql.detachDatabase",
"when": "connectionProvider == MSSQL && nodeType == Database && !isCloud && config.workbench.enablePreviewFeatures", "when": "connectionProvider == MSSQL && nodeType == Database && !isCloud && config.workbench.enablePreviewFeatures",
"group": "0_query@4" "group": "1_objectManagement"
}, },
{ {
"command": "mssql.enableGroupBySchema", "command": "mssql.enableGroupBySchema",
@@ -600,27 +604,27 @@
{ {
"command": "mssql.newObject", "command": "mssql.newObject",
"when": "connectionProvider == MSSQL && nodeType == Folder && objectType =~ /^(ServerLevelLogins|Users|ServerLevelServerRoles|ApplicationRoles|DatabaseRoles|Databases)$/ && config.workbench.enablePreviewFeatures", "when": "connectionProvider == MSSQL && nodeType == Folder && objectType =~ /^(ServerLevelLogins|Users|ServerLevelServerRoles|ApplicationRoles|DatabaseRoles|Databases)$/ && config.workbench.enablePreviewFeatures",
"group": "connection@1" "group": "1_objectManagement"
}, },
{ {
"command": "mssql.objectProperties", "command": "mssql.objectProperties",
"when": "connectionProvider == MSSQL && nodeType =~ /^(ServerLevelLogin|User|ServerLevelServerRole|ApplicationRole|DatabaseRole)$/ && config.workbench.enablePreviewFeatures", "when": "connectionProvider == MSSQL && nodeType =~ /^(ServerLevelLogin|User|ServerLevelServerRole|ApplicationRole|DatabaseRole)$/ && config.workbench.enablePreviewFeatures",
"group": "connection@1" "group": "z_objectManagement"
}, },
{ {
"command": "mssql.deleteObject", "command": "mssql.deleteObject",
"when": "connectionProvider == MSSQL && nodeType =~ /^(ServerLevelLogin|User|ServerLevelServerRole|ApplicationRole|DatabaseRole|Database)$/ && config.workbench.enablePreviewFeatures", "when": "connectionProvider == MSSQL && nodeType =~ /^(ServerLevelLogin|User|ServerLevelServerRole|ApplicationRole|DatabaseRole|Database)$/ && config.workbench.enablePreviewFeatures",
"group": "connection@2" "group": "1_objectManagement"
}, },
{ {
"command": "mssql.renameObject", "command": "mssql.renameObject",
"when": "connectionProvider == MSSQL && nodeType =~ /^(ServerLevelLogin|User|Table|View|ServerLevelServerRole|ApplicationRole|DatabaseRole)$/ && config.workbench.enablePreviewFeatures", "when": "connectionProvider == MSSQL && nodeType =~ /^(ServerLevelLogin|User|Table|View|ServerLevelServerRole|ApplicationRole|DatabaseRole)$/ && config.workbench.enablePreviewFeatures",
"group": "connection@3" "group": "1_objectManagement"
}, },
{ {
"command": "mssql.renameObject", "command": "mssql.renameObject",
"when": "connectionProvider == MSSQL && nodeType == Column && config.workbench.enablePreviewFeatures && nodePath =~ /^.*\\/Tables\\/.*\\/Columns\\/.*$/", "when": "connectionProvider == MSSQL && nodeType == Column && config.workbench.enablePreviewFeatures && nodePath =~ /^.*\\/Tables\\/.*\\/Columns\\/.*$/",
"group": "connection@3" "group": "1_objectManagement"
}, },
{ {
"command": "mssql.enableGroupBySchema", "command": "mssql.enableGroupBySchema",

View File

@@ -184,9 +184,9 @@
"mssql.objectExplorer.enableGroupBySchemaTitle": "SQL Server: Enable Group By Schema", "mssql.objectExplorer.enableGroupBySchemaTitle": "SQL Server: Enable Group By Schema",
"mssql.objectExplorer.disableGroupBySchemaTitle": "SQL Server: Disable Group By Schema", "mssql.objectExplorer.disableGroupBySchemaTitle": "SQL Server: Disable Group By Schema",
"mssql.objectExplorer.expandTimeout": "The timeout in seconds for expanding a node in Object Explorer. The default value is 45 seconds.", "mssql.objectExplorer.expandTimeout": "The timeout in seconds for expanding a node in Object Explorer. The default value is 45 seconds.",
"title.newObject": "New", "title.newObject": "New (Preview)",
"title.objectProperties": "Properties (Preview)", "title.objectProperties": "Properties (Preview)",
"title.deleteObject": "Delete", "title.deleteObject": "Delete (Preview)",
"title.renameObject": "Rename", "title.renameObject": "Rename (Preview)",
"title.detachDatabase": "Detach" "title.detachDatabase": "Detach (Preview)"
} }

View File

@@ -126,7 +126,7 @@ CommandsRegistry.registerCommand({
MenuRegistry.appendMenuItem(MenuId.DataExplorerContext, { MenuRegistry.appendMenuItem(MenuId.DataExplorerContext, {
group: '0_query', group: '0_query',
order: 3, order: 1,
command: { command: {
id: DE_NEW_NOTEBOOK_COMMAND_ID, id: DE_NEW_NOTEBOOK_COMMAND_ID,
title: localize('newNotebook', "New Notebook") title: localize('newNotebook', "New Notebook")
@@ -148,7 +148,7 @@ CommandsRegistry.registerCommand({
MenuRegistry.appendMenuItem(MenuId.ObjectExplorerItemContext, { MenuRegistry.appendMenuItem(MenuId.ObjectExplorerItemContext, {
group: '0_query', group: '0_query',
order: 3, order: 1,
command: { command: {
id: OE_NEW_NOTEBOOK_COMMAND_ID, id: OE_NEW_NOTEBOOK_COMMAND_ID,
title: localize('newQuery', "New Notebook") title: localize('newQuery', "New Notebook")

View File

@@ -71,7 +71,7 @@ new NewQueryTask().registerTask();
MenuRegistry.appendMenuItem(MenuId.ObjectExplorerItemContext, { MenuRegistry.appendMenuItem(MenuId.ObjectExplorerItemContext, {
group: '0_query', group: '0_query',
order: 1, order: 0,
command: { command: {
id: OE_NEW_QUERY_ACTION_ID, id: OE_NEW_QUERY_ACTION_ID,
title: localize('newQuery', "New Query") title: localize('newQuery', "New Query")
@@ -82,7 +82,7 @@ MenuRegistry.appendMenuItem(MenuId.ObjectExplorerItemContext, {
// New Query // New Query
MenuRegistry.appendMenuItem(MenuId.DataExplorerContext, { MenuRegistry.appendMenuItem(MenuId.DataExplorerContext, {
group: '0_query', group: '0_query',
order: 1, order: 0,
command: { command: {
id: DE_NEW_QUERY_COMMAND_ID, id: DE_NEW_QUERY_COMMAND_ID,
title: localize('newQuery', "New Query") title: localize('newQuery', "New Query")