ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

[SQL Migration] Remove noisy telemetry error event (#23348)

Browse Source 
* Remove RefreshDataCollectionFailed

* Fix timer initialization

* Add refresh
This commit is contained in:
Raymond Truong
2023-06-07 16:01:17 -07:00
committed by GitHub
parent e0d5cd18b9
commit dd277e3f57
2 changed files with 7 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
extensions/sql-migration/src/models/stateMachine.ts
View File

@@ -659,7 +659,7 @@ export class MigrationStateModel implements Model, vscode.Disposable {
void vscode.window.showInformationMessage(constants.AZURE_RECOMMENDATION_START_POPUP); void vscode.window.showInformationMessage(constants.AZURE_RECOMMENDATION_START_POPUP);
await this.startSkuTimers(page, this.refreshPerfDataCollectionFrequency); await this.startSkuTimers(page);
} }
} }
catch (error) { catch (error) {
@@ -688,7 +688,7 @@ export class MigrationStateModel implements Model, vscode.Disposable {
} }
} }
public async startSkuTimers(page: SKURecommendationPage, refreshIntervalInMs: number): Promise<void> { public async startSkuTimers(page: SKURecommendationPage): Promise<void> {
const classVariable = this; const classVariable = this;
if (!this._autoRefreshPerfDataCollectionHandle) { if (!this._autoRefreshPerfDataCollectionHandle) {
@@ -701,7 +701,7 @@ export class MigrationStateModel implements Model, vscode.Disposable {
await page.refreshSkuRecommendationComponents(); // update timer await page.refreshSkuRecommendationComponents(); // update timer
} }
}, },
refreshIntervalInMs); this.refreshPerfDataCollectionFrequency);
} }
} }
@@ -773,7 +773,7 @@ export class MigrationStateModel implements Model, vscode.Disposable {
} }
} }
catch (error) { catch (error) {
logError(TelemetryViews.DataCollectionWizard, 'RefreshDataCollectionFailed', error); console.log(error); // use console.log() instead of logError() to avoid spamming telemetry with this error, which can be frequent
} }
return true; return true;

9
extensions/sql-migration/src/wizard/skuRecommendationPage.ts
View File

@@ -556,12 +556,9 @@ export class SKURecommendationPage extends MigrationWizardPage {
// check if collector is still running // check if collector is still running
await this.migrationStateModel.refreshPerfDataCollection(); await this.migrationStateModel.refreshPerfDataCollection();
if (this.migrationStateModel._perfDataCollectionIsCollecting) { if (this.migrationStateModel._perfDataCollectionIsCollecting) {
// user started collecting data, and the collector is still running // user started collecting data, ensure the collector is still running
const collectionStartTime = new Date(this.migrationStateModel._perfDataCollectionStartDate!); await this.migrationStateModel.startSkuTimers(this);
const expectedRefreshTime = new Date(collectionStartTime.getTime() + this.migrationStateModel.refreshGetSkuRecommendationFrequency); await this.refreshSkuRecommendationComponents();
const timeLeft = Math.abs(new Date().getTime() - expectedRefreshTime.getTime());
await this.migrationStateModel.startSkuTimers(this, timeLeft);
} else { } else {
// user started collecting data, but collector is stopped // user started collecting data, but collector is stopped
// set stop date to some date value // set stop date to some date value