Notebooks: fix save as csv/excel/json/xml (#14882)

* add getEncoding method to notebooks

* fix row 501 missing in serialization

* fix row index

* pr comment
This commit is contained in:
Lucy Zhang
2021-03-29 07:14:49 -07:00
committed by GitHub
parent ca19f08582
commit dd5adad772
4 changed files with 15 additions and 4 deletions

View File

@@ -119,6 +119,10 @@ export class SerializationService implements ISerializationService {
let index = 0;
let startRequestParams = this.createStartRequest(serializationRequest, index);
index = index + startRequestParams.rows.length;
// Adjust row index based on whether or not header row is included
if (serializationRequest.includeHeaders) {
index--;
}
let startResult = await provider.startSerialization(startRequestParams);