Renable Strict TSLint (#5018)

* removes more builder references

* remove builder from profiler

* formatting

* fix profiler dailog

* remove builder from oatuhdialog

* remove the rest of builder references

* formatting

* add more strict null checks to base

* enable strict tslint rules

* fix formatting

* fix compile error

* fix the rest of the hygeny issues and add pipeline step

* fix pipeline files

extensions/import/src/controllers/controllerBase.ts

@@ -1,4 +1,3 @@
-
 /*---------------------------------------------------------------------------------------------
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the Source EULA. See License.txt in the project root for license information.

extensions/import/src/services/contracts.ts

@@ -2,13 +2,9 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-'use strict';
 
 import { RequestType, NotificationType } from 'vscode-languageclient';
 
-/**
- * @interface IMessage
- */
 export interface IMessage {
 	jsonrpc: string;
 }

extensions/import/src/services/serviceUtils.ts

@@ -2,7 +2,6 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-'use strict';
 
 import * as path from 'path';
 import * as crypto from 'crypto';
@@ -97,7 +96,7 @@ export function generateGuid(): string {
 }
 
 export function verifyPlatform(): Thenable<boolean> {
-	if (os.platform() === 'darwin' && parseFloat(os.release()) < 16.0) {
+	if (os.platform() === 'darwin' && parseFloat(os.release()) < 16) {
 		return Promise.resolve(false);
 	} else {
 		return Promise.resolve(true);

extensions/import/src/services/telemetry.ts

@@ -3,8 +3,6 @@
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
-
 import { ErrorAction, CloseAction } from 'vscode-languageclient';
 import TelemetryReporter from 'vscode-extension-telemetry';
 import { PlatformInformation } from 'service-downloader/out/platform';
@@ -20,22 +18,21 @@ import { IMessage, ITelemetryEventProperties, ITelemetryEventMeasures } from './
 
 /**
  * Handle Language Service client errors
- * @class LanguageClientErrorHandler
  */
 export class LanguageClientErrorHandler {
 
-    /**
-     * Creates an instance of LanguageClientErrorHandler.
-     * @memberOf LanguageClientErrorHandler
-     */
+	/**
+	 * Creates an instance of LanguageClientErrorHandler.
+	 * @memberOf LanguageClientErrorHandler
+	 */
 	constructor() {
 
 	}
 
-    /**
-     * Show an error message prompt with a link to known issues wiki page
-     * @memberOf LanguageClientErrorHandler
-     */
+	/**
+	 * Show an error message prompt with a link to known issues wiki page
+	 * @memberOf LanguageClientErrorHandler
+	 */
 	showOnErrorPrompt(): void {
 		// TODO add telemetry
 		// Telemetry.sendTelemetryEvent('SqlToolsServiceCrash');
@@ -50,16 +47,11 @@ export class LanguageClientErrorHandler {
 		});
 	}
 
-    /**
-     * Callback for language service client error
-     *
-     * @param {Error} error
-     * @param {Message} message
-     * @param {number} count
-     * @returns {ErrorAction}
-     *
-     * @memberOf LanguageClientErrorHandler
-     */
+	/**
+	 * Callback for language service client error
+	 *
+	 * @memberOf LanguageClientErrorHandler
+	 */
 	error(error: Error, message: IMessage, count: number): ErrorAction {
 		this.showOnErrorPrompt();
 
@@ -68,13 +60,11 @@ export class LanguageClientErrorHandler {
 		return ErrorAction.Shutdown;
 	}
 
-    /**
-     * Callback for language service client closed
-     *
-     * @returns {CloseAction}
-     *
-     * @memberOf LanguageClientErrorHandler
-     */
+	/**
+	 * Callback for language service client closed
+	 *
+	 * @memberOf LanguageClientErrorHandler
+	 */
 	closed(): CloseAction {
 		this.showOnErrorPrompt();
 
@@ -134,16 +124,16 @@ export class Telemetry {
 		}
 	}
 
-    /**
-     * Disable telemetry reporting
-     */
+	/**
+	 * Disable telemetry reporting
+	 */
 	public static disable(): void {
 		this.disabled = true;
 	}
 
-    /**
-     * Initialize the telemetry reporter for use.
-     */
+	/**
+	 * Initialize the telemetry reporter for use.
+	 */
 	public static initialize(): void {
 		if (typeof this.reporter === 'undefined') {
 			// Check if the user has opted out of telemetry
@@ -156,9 +146,9 @@ export class Telemetry {
 		}
 	}
 
-    /**
-     * Send a telemetry event for an exception
-     */
+	/**
+	 * Send a telemetry event for an exception
+	 */
 	public static sendTelemetryEventForException(
 		err: any, methodName: string, extensionConfigName: string): void {
 		try {
@@ -181,9 +171,9 @@ export class Telemetry {
 		}
 	}
 
-    /**
-     * Send a telemetry event using application insights
-     */
+	/**
+	 * Send a telemetry event using application insights
+	 */
 	public static sendTelemetryEvent(
 		eventName: string,
 		properties?: ITelemetryEventProperties,

extensions/import/src/wizard/api/basePage.ts

@@ -2,7 +2,6 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-'use strict';
 
 import * as azdata from 'azdata';
 import { ImportDataModel } from './models';
@@ -15,19 +14,16 @@ export abstract class BasePage {
 
 	/**
 	 * This method constructs all the elements of the page.
-	 * @returns {Promise<boolean>}
 	 */
 	public async abstract start(): Promise<boolean>;
 
 	/**
 	 * This method is called when the user is entering the page.
-	 * @returns {Promise<boolean>}
 	 */
 	public async abstract onPageEnter(): Promise<boolean>;
 
 	/**
 	 * This method is called when the user is leaving the page.
-	 * @returns {Promise<boolean>}
 	 */
 	async onPageLeave(): Promise<boolean> {
 		return true;
@@ -35,7 +31,6 @@ export abstract class BasePage {
 
 	/**
 	 * Override this method to cleanup what you don't need cached in the page.
-	 * @returns {Promise<boolean>}
 	 */
 	public async cleanup(): Promise<boolean> {
 		return true;
@@ -136,4 +131,3 @@ export abstract class BasePage {
 		return;
 	}
 }
-

extensions/import/src/wizard/pages/summaryPage.ts

@@ -3,8 +3,6 @@
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
-
 import * as azdata from 'azdata';
 import * as nls from 'vscode-nls';
 
@@ -133,7 +131,6 @@ export class SummaryPage extends ImportPage {
 
 	/**
 	 * Gets the connection string to send to the middleware
-	 * @returns {Promise<string>}
 	 */
 	private async getConnectionString(): Promise<string> {
 		let options = this.model.server.options;