Renable Strict TSLint (#5018)

* removes more builder references

* remove builder from profiler

* formatting

* fix profiler dailog

* remove builder from oatuhdialog

* remove the rest of builder references

* formatting

* add more strict null checks to base

* enable strict tslint rules

* fix formatting

* fix compile error

* fix the rest of the hygeny issues and add pipeline step

* fix pipeline files

extensions/profiler/client/src/apiWrapper.ts

@@ -3,61 +3,57 @@
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
 import * as vscode from 'vscode';
 import * as data from 'azdata';
 
 /**
  * Wrapper class to act as a facade over VSCode and Data APIs and allow us to test / mock callbacks into
  * this API from our code
- *
- * @export
- * @class ApiWrapper
  */
 export class ApiWrapper {
-    // Data APIs
+	// Data APIs
 
-    public registerWebviewProvider(widgetId: string, handler: (webview: data.DashboardWebview) => void): void {
-        return data.dashboard.registerWebviewProvider(widgetId, handler);
-    }
+	public registerWebviewProvider(widgetId: string, handler: (webview: data.DashboardWebview) => void): void {
+		return data.dashboard.registerWebviewProvider(widgetId, handler);
+	}
 
 
-    public registerControlHostProvider(widgetId: string, handler: (webview: data.DashboardWebview) => void): void {
-        return data.dashboard.registerWebviewProvider(widgetId, handler);
-    }
+	public registerControlHostProvider(widgetId: string, handler: (webview: data.DashboardWebview) => void): void {
+		return data.dashboard.registerWebviewProvider(widgetId, handler);
+	}
 
-    /**
-     * Get the configuration for a extensionName
-     * @param extensionName The string name of the extension to get the configuration for
-     * @param resource The optional URI, as a URI object or a string, to use to get resource-scoped configurations
-     */
-    public getConfiguration(extensionName: string, resource?: vscode.Uri | string): vscode.WorkspaceConfiguration {
-        if (typeof resource === 'string') {
-            try {
-                resource = this.parseUri(resource);
-            } catch (e) {
-                resource = undefined;
-            }
-        }
-        return vscode.workspace.getConfiguration(extensionName, resource as vscode.Uri);
-    }
+	/**
+	 * Get the configuration for a extensionName
+	 * @param extensionName The string name of the extension to get the configuration for
+	 * @param resource The optional URI, as a URI object or a string, to use to get resource-scoped configurations
+	 */
+	public getConfiguration(extensionName: string, resource?: vscode.Uri | string): vscode.WorkspaceConfiguration {
+		if (typeof resource === 'string') {
+			try {
+				resource = this.parseUri(resource);
+			} catch (e) {
+				resource = undefined;
+			}
+		}
+		return vscode.workspace.getConfiguration(extensionName, resource as vscode.Uri);
+	}
 
-    /**
-     * Parse uri
-     */
-    public parseUri(uri: string): vscode.Uri {
-        return vscode.Uri.parse(uri);
-    }
+	/**
+	 * Parse uri
+	 */
+	public parseUri(uri: string): vscode.Uri {
+		return vscode.Uri.parse(uri);
+	}
 
-    public showOpenDialog(options: vscode.OpenDialogOptions): Thenable<vscode.Uri[] | undefined> {
-        return vscode.window.showOpenDialog(options);
-    }
+	public showOpenDialog(options: vscode.OpenDialogOptions): Thenable<vscode.Uri[] | undefined> {
+		return vscode.window.showOpenDialog(options);
+	}
 
-    public showErrorMessage(message: string, ...items: string[]): Thenable<string | undefined> {
-        return vscode.window.showErrorMessage(message, ...items);
-    }
+	public showErrorMessage(message: string, ...items: string[]): Thenable<string | undefined> {
+		return vscode.window.showErrorMessage(message, ...items);
+	}
 
-    public get workspaceRootPath(): string {
-        return vscode.workspace.rootPath;
-    }
+	public get workspaceRootPath(): string {
+		return vscode.workspace.rootPath;
+	}
 }

extensions/profiler/client/src/mainController.ts

@@ -22,9 +22,9 @@ export class MainController {
 		this._context = context;
 	}
 
-    /**
-     * Deactivates the extension
-     */
+	/**
+	 * Deactivates the extension
+	 */
 	public deactivate(): void {
 	}
 

extensions/profiler/client/tsconfig.json

@@ -1,19 +1,18 @@
 {
-    "compileOnSave": true,
-    "compilerOptions": {
-        "module": "commonjs",
-        "target": "es6",
+	"compileOnSave": true,
+	"compilerOptions": {
+		"module": "commonjs",
+		"target": "es6",
 		"outDir": "./out",
 		"lib": [
 			"es6", "es2015.promise"
 		],
-        "sourceMap": true,
-        "emitDecoratorMetadata": true,
-        "experimentalDecorators": true,
-        "moduleResolution": "node",
-        "declaration": true
-    },
-    "exclude": [
-        "node_modules"
-    ]
+		"sourceMap": true,
+		"emitDecoratorMetadata": true,
+		"experimentalDecorators": true,
+		"moduleResolution": "node"
+	},
+	"exclude": [
+		"node_modules"
+	]
 }