Renable Strict TSLint (#5018)

* removes more builder references * remove builder from profiler * formatting * fix profiler dailog * remove builder from oatuhdialog * remove the rest of builder references * formatting * add more strict null checks to base * enable strict tslint rules * fix formatting * fix compile error * fix the rest of the hygeny issues and add pipeline step * fix pipeline files
2026-01-25 09:35:37 -05:00 · 2019-04-18 00:34:53 -07:00
parent b852f032d3
commit ddd89fc52a
431 changed files with 3147 additions and 3789 deletions
--- a/src/sql/base/browser/ui/checkbox/media/checkbox.css
+++ b/src/sql/base/browser/ui/checkbox/media/checkbox.css
@@ -3,7 +3,7 @@
 *  Licensed under the Source EULA. See License.txt in the project root for license information.
 *--------------------------------------------------------------------------------------------*/

- .custom-checkbox.sql-checkbox {
+.custom-checkbox.sql-checkbox {
 	margin-right: 5px;
 	margin-top: 2px;
 	width: 12px;
--- a/src/sql/base/browser/ui/editableDropdown/dropdown.ts
+++ b/src/sql/base/browser/ui/editableDropdown/dropdown.ts
@@ -107,7 +107,7 @@ export class Dropdown extends Disposable {
 		super();
 		this._contextView = new ContextView(layoutService.container);
 		this._options = opt || Object.create(null);
-		mixin(this._options, defaults, false) as IDropdownOptions;
+		mixin(this._options, defaults, false);
 		this._el = DOM.append(container, DOM.$('.monaco-dropdown'));
 		this._el.style.width = '100%';

--- a/src/sql/base/browser/ui/selectBox/media/selectBox.css
+++ b/src/sql/base/browser/ui/selectBox/media/selectBox.css
@@ -1,10 +1,15 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
 .labelOnTopContainer {
-    display: flex;
-    flex-direction: column;
+	display: flex;
+	flex-direction: column;
 }

 .labelOnLeftContainer {
-    display: flex;
-    flex-direction: row;
-    margin-right: 5px;
+	display: flex;
+	flex-direction: row;
+	margin-right: 5px;
 }
--- a/src/sql/base/browser/ui/table/media/slick.grid.css
+++ b/src/sql/base/browser/ui/table/media/slick.grid.css
@@ -1,9 +1,7 @@
-/*
-IMPORTANT:
-In order to preserve the uniform grid appearance, all cell styles need to have padding, margin and border sizes.
-No built-in (selected, editable, highlight, flashing, invalid, loading, :focus) or user-specified CSS
-classes should alter those!
-*/
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/

 .slick-header.ui-state-default, .slick-headerrow.ui-state-default, .slick-footerrow.ui-state-default  {
 	width: 100%;
--- a/src/sql/base/browser/ui/table/media/slickColorTheme.css
+++ b/src/sql/base/browser/ui/table/media/slickColorTheme.css
@@ -71,7 +71,7 @@
 /* grid styling */

 .vs slick-grid.active .grid .slick-cell.active {
-  border-color: var(--color-cell-border-active);
+	border-color: var(--color-cell-border-active);
 }

 .vs slick-grid.active .grid .slick-cell.selected {
@@ -202,7 +202,7 @@
 /* grid styling */

 .vs-dark slick-grid.active .grid .slick-cell.active {
-  border-color: var(--color-cell-border-active);
+	border-color: var(--color-cell-border-active);
 }

 .vs-dark slick-grid.active .grid .slick-cell.selected {
@@ -348,7 +348,7 @@
 /* grid styling */

 .hc-black slick-grid.active .grid .slick-cell.active {
-  border-color: var(--color-cell-border-active);
+	border-color: var(--color-cell-border-active);
 }

 .hc-black slick-grid.active .grid .slick-cell.selected {
--- a/src/sql/base/browser/ui/table/media/table.css
+++ b/src/sql/base/browser/ui/table/media/table.css
@@ -35,129 +35,129 @@
 }

 .slick-header-menubutton {
-    background-position: center center;
-    background-repeat: no-repeat;
-    bottom: 0;
-    cursor: pointer;
-    display: inline-block;
-    position: absolute;
-    right: 10px;
-    top: 0;
-    width: 18px;
-    background-image: url('down.svg');
+	background-position: center center;
+	background-repeat: no-repeat;
+	bottom: 0;
+	cursor: pointer;
+	display: inline-block;
+	position: absolute;
+	right: 10px;
+	top: 0;
+	width: 18px;
+	background-image: url('down.svg');
 }

 .vs-dark .slick-header-menubutton,
 .hc-black .slick-header-menubutton {
-    background-image: url('down-inverse.svg');
+	background-image: url('down-inverse.svg');
 }

 .slick-header-menubutton.filtered {
-    background-image: url('filter.svg');
+	background-image: url('filter.svg');
 }

 .vs-dark .slick-header-menubutton.filtered,
 .hc-black .slick-header-menubutton.filtered {
-    background-image: url('filter_inverse.svg');
+	background-image: url('filter_inverse.svg');
 }

 .slick-header-menu {
-    background: none repeat scroll 0 0 white;
-    border: 1px solid #BFBDBD;
-    min-width: 175px;
-    padding: 4px;
-    z-index: 100000;
-    cursor: default;
-    display: inline-block;
-    margin: 0;
-    position: absolute;
+	background: none repeat scroll 0 0 white;
+	border: 1px solid #BFBDBD;
+	min-width: 175px;
+	padding: 4px;
+	z-index: 100000;
+	cursor: default;
+	display: inline-block;
+	margin: 0;
+	position: absolute;
 }

 .vs-dark .slick-header-menu {
-    background: none repeat scroll 0 0 #333333;
+	background: none repeat scroll 0 0 #333333;
 }

 .hc-black .slick-header-menu {
-    background: none repeat scroll 0 0 #000000;
+	background: none repeat scroll 0 0 #000000;
 }

 .slick-header-menu a.monaco-button.monaco-text-button {
-    width: 60px;
-    margin: 6px 6px 6px 6px;
-    padding: 4px;
+	width: 60px;
+	margin: 6px 6px 6px 6px;
+	padding: 4px;
 }

 .slick-header-menu .filter
 {
-    border: 1px solid #BFBDBD;
-    font-size: 8pt;
-    height: 250px;
-    margin-top: 6px;
-    overflow: scroll;
-    padding: 4px;
-    white-space: nowrap;
-    width: 200px;
+	border: 1px solid #BFBDBD;
+	font-size: 8pt;
+	height: 250px;
+	margin-top: 6px;
+	overflow: scroll;
+	padding: 4px;
+	white-space: nowrap;
+	width: 200px;
 }

 .monaco-table label {
-    display: block;
-    margin-bottom: 5px;
+	display: block;
+	margin-bottom: 5px;
 }

 .slick-header-menuitem
 {
-    border: 1px solid transparent;
-    padding: 2px 4px;
-    cursor: pointer;
-    list-style: none outside none;
-    margin: 0;
+	border: 1px solid transparent;
+	padding: 2px 4px;
+	cursor: pointer;
+	list-style: none outside none;
+	margin: 0;
 }

 .slick-header-menuicon
 {
-    display: inline-block;
-    height: 16px;
-    margin-right: 4px;
-    vertical-align: middle;
-    width: 16px;
+	display: inline-block;
+	height: 16px;
+	margin-right: 4px;
+	vertical-align: middle;
+	width: 16px;
 }

 .slick-header-menuicon.ascending {
-    background: url('sort-asc.gif');
-    background-position: center center;
-    background-repeat: no-repeat;
+	background: url('sort-asc.gif');
+	background-position: center center;
+	background-repeat: no-repeat;
 }

 .slick-header-menuicon.descending {
-    background: url('sort-desc.gif');
-    background-position: center center;
-    background-repeat: no-repeat;
+	background: url('sort-desc.gif');
+	background-position: center center;
+	background-repeat: no-repeat;
 }

 .slick-header-menucontent {
-    display: inline-block;
-    vertical-align: middle;
+	display: inline-block;
+	vertical-align: middle;
 }

 .slick-header-menuitem:hover {
-    border-color: #BFBDBD;
+	border-color: #BFBDBD;
 }

 .header-overlay, .cell-overlay, .selection-cell-overlay {
-    display: block;
-    position: absolute;
-    z-index: 999;
+	display: block;
+	position: absolute;
+	z-index: 999;
 }

 .vs-dark .slick-header-menu > input.input {
-    color: #4a4a4a;
+	color: #4a4a4a;
 }

 .hc-black .slick-header-menu > input.input {
-    color: #000000;
+	color: #000000;
 }

 .vs-dark .slick-header-menu,
 .hc-black .slick-header-menu {
-    color: #FFFFFF;
-}
+	color: #FFFFFF;
+}
--- a/src/sql/base/browser/ui/table/plugins/cellRangeSelector.ts
+++ b/src/sql/base/browser/ui/table/plugins/cellRangeSelector.ts
@@ -1,3 +1,8 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
 import { mixin } from 'vs/base/common/objects';

 const defaultOptions: ICellRangeSelectorOptions = {
--- a/src/sql/base/browser/ui/taskbar/media/taskbar.css
+++ b/src/sql/base/browser/ui/taskbar/media/taskbar.css
@@ -48,12 +48,12 @@
 	background-repeat: no-repeat;
 	background-position: 0% 50%;
 	padding-left: 15px;
- }
+}

- .carbon-taskbar .action-item-label {
+.carbon-taskbar .action-item-label {
 	display: flex;
 	padding-right: 5px;
- }
+}

 .listDatabasesSelectBox {
 	padding-left: 2px;
@@ -64,7 +64,7 @@
 .configuration.select-container .select-box {
 	margin-top: 4px;
 	margin-top: 3px;
- }
+}

 .taskbarSeparator {
 	width: 1px;