Renable Strict TSLint (#5018)

* removes more builder references

* remove builder from profiler

* formatting

* fix profiler dailog

* remove builder from oatuhdialog

* remove the rest of builder references

* formatting

* add more strict null checks to base

* enable strict tslint rules

* fix formatting

* fix compile error

* fix the rest of the hygeny issues and add pipeline step

* fix pipeline files

src/sql/platform/accounts/common/accountPickerViewModel.ts

@@ -33,7 +33,7 @@ export class AccountPickerViewModel {
 	// PUBLIC METHODS //////////////////////////////////////////////////////
 	/**
 	 * Loads an initial list of accounts from the account management service
-	 * @return {Thenable<Account[]>} Promise to return the list of accounts
+	 * @return Promise to return the list of accounts
 	 */
 	public initialize(): Thenable<azdata.Account[]> {
 		// Load a baseline of the accounts for the provider

src/sql/platform/accounts/common/accountStore.ts

@@ -1,7 +1,7 @@
 /*---------------------------------------------------------------------------------------------
-*  Copyright (c) Microsoft Corporation. All rights reserved.
-*  Licensed under the Source EULA. See License.txt in the project root for license information.
-*--------------------------------------------------------------------------------------------*/
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
 
 import * as azdata from 'azdata';
 import { AccountAdditionResult } from 'sql/platform/accounts/common/eventTypes';

src/sql/platform/accounts/common/interfaces.ts

@@ -50,21 +50,21 @@ export enum AzureResource {
 export interface IAccountStore {
 	/**
 	 * Adds the provided account if the account doesn't exist. Updates the account if it already exists
-	 * @param {Account} account Account to add/update
-	 * @return {Thenable<AccountAdditionResult>} Results of the add/update operation
+	 * @param account Account to add/update
+	 * @return Results of the add/update operation
 	 */
 	addOrUpdate(account: azdata.Account): Thenable<AccountAdditionResult>;
 
 	/**
 	 * Retrieves all accounts, filtered by provider ID
-	 * @param {string} providerId ID of the provider to filter by
-	 * @return {Thenable<Account[]>} Promise to return all accounts that belong to the provided provider
+	 * @param providerId ID of the provider to filter by
+	 * @return Promise to return all accounts that belong to the provided provider
 	 */
 	getAccountsByProvider(providerId: string): Thenable<azdata.Account[]>;
 
 	/**
 	 * Retrieves all accounts in the store. Returns empty array if store is not initialized
-	 * @return {Thenable<Account[]>} Promise to return all accounts
+	 * @return Promise to return all accounts
 	 */
 	getAllAccounts(): Thenable<azdata.Account[]>;