Renable Strict TSLint (#5018)

* removes more builder references

* remove builder from profiler

* formatting

* fix profiler dailog

* remove builder from oatuhdialog

* remove the rest of builder references

* formatting

* add more strict null checks to base

* enable strict tslint rules

* fix formatting

* fix compile error

* fix the rest of the hygeny issues and add pipeline step

* fix pipeline files

src/sql/workbench/parts/dashboard/common/componentHost.directive.ts

@@ -1,7 +1,7 @@
 /*---------------------------------------------------------------------------------------------
-*  Copyright (c) Microsoft Corporation. All rights reserved.
-*  Licensed under the Source EULA. See License.txt in the project root for license information.
-*--------------------------------------------------------------------------------------------*/
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
 
 import { Directive, ViewContainerRef, Inject, forwardRef } from '@angular/core';
 
@@ -9,5 +9,5 @@ import { Directive, ViewContainerRef, Inject, forwardRef } from '@angular/core';
 	selector: '[component-host]',
 })
 export class ComponentHostDirective {
-	constructor( @Inject(forwardRef(() => ViewContainerRef)) public viewContainerRef: ViewContainerRef) { }
+	constructor(@Inject(forwardRef(() => ViewContainerRef)) public viewContainerRef: ViewContainerRef) { }
 }

src/sql/workbench/parts/dashboard/containers/dashboardControlHostContainer.component.ts

@@ -1,7 +1,7 @@
 /*---------------------------------------------------------------------------------------------
-*  Copyright (c) Microsoft Corporation. All rights reserved.
-*  Licensed under the Source EULA. See License.txt in the project root for license information.
-*--------------------------------------------------------------------------------------------*/
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
 
 import 'vs/css!./dashboardControlHostContainer';
 

src/sql/workbench/parts/dashboard/containers/dashboardControlHostContainer.css

@@ -3,7 +3,7 @@
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
- dashboard-controlhost-container {
+dashboard-controlhost-container {
 	height: 100%;
 	width : 100%;
 	display: block;

src/sql/workbench/parts/dashboard/containers/dashboardHomeContainer.css

@@ -3,7 +3,7 @@
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
- dashboard-home-tab {
+dashboard-home-tab {
 	height: 100%;
 	width: 100%;
 	display: block;

src/sql/workbench/parts/dashboard/containers/dashboardModelViewContainer.component.ts

@@ -1,7 +1,7 @@
 /*---------------------------------------------------------------------------------------------
-*  Copyright (c) Microsoft Corporation. All rights reserved.
-*  Licensed under the Source EULA. See License.txt in the project root for license information.
-*--------------------------------------------------------------------------------------------*/
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
 
 import 'vs/css!./dashboardWebviewContainer';
 

src/sql/workbench/parts/dashboard/containers/dashboardWebviewContainer.component.ts

@@ -1,7 +1,7 @@
 /*---------------------------------------------------------------------------------------------
-*  Copyright (c) Microsoft Corporation. All rights reserved.
-*  Licensed under the Source EULA. See License.txt in the project root for license information.
-*--------------------------------------------------------------------------------------------*/
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
 
 import 'vs/css!./dashboardWebviewContainer';
 

src/sql/workbench/parts/dashboard/contents/controlHostContent.component.ts

@@ -1,7 +1,7 @@
 /*---------------------------------------------------------------------------------------------
-*  Copyright (c) Microsoft Corporation. All rights reserved.
-*  Licensed under the Source EULA. See License.txt in the project root for license information.
-*--------------------------------------------------------------------------------------------*/
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
 
 import 'vs/css!./controlHostContent';
 

src/sql/workbench/parts/dashboard/contents/controlHostContent.css

@@ -3,7 +3,7 @@
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
- controlhost-content {
+controlhost-content {
 	height: 100%;
 	width : 100%;
 	display: block;

src/sql/workbench/parts/dashboard/contents/dashboardWidgetWrapper.component.ts

@@ -197,11 +197,6 @@ export class DashboardWidgetWrapper extends AngularDisposable implements OnInit
 	/**
 	 * Attempts to get the selector for a given key, and if none is defined tries
 	 * to load it from the widget registry and configure as needed
-	 *
-	 * @private
-	 * @param {string} key
-	 * @returns {Type<IDashboardWidget>}
-	 * @memberof DashboardWidgetWrapper
 	 */
 	private getOrCreateSelector(key: string): Type<IDashboardWidget> {
 		let selector = componentMap[key];

src/sql/workbench/parts/dashboard/contents/webviewContent.component.ts

@@ -1,7 +1,7 @@
 /*---------------------------------------------------------------------------------------------
-*  Copyright (c) Microsoft Corporation. All rights reserved.
-*  Licensed under the Source EULA. See License.txt in the project root for license information.
-*--------------------------------------------------------------------------------------------*/
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
 
 import 'vs/css!./webviewContent';
 

src/sql/workbench/parts/dashboard/dashboard.component.ts

@@ -1,7 +1,7 @@
 /*---------------------------------------------------------------------------------------------
-*  Copyright (c) Microsoft Corporation. All rights reserved.
-*  Licensed under the Source EULA. See License.txt in the project root for license information.
-*--------------------------------------------------------------------------------------------*/
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
 
 import 'vs/css!./dashboard';
 

src/sql/workbench/parts/dashboard/widgets/insights/views/charts/chartInsight.component.ts

@@ -293,7 +293,7 @@ function isValidData(data: IInsightData): boolean {
 Chart.pluginService.register({
 	beforeDraw: function (chart) {
 		if (chart.config.options.viewArea && chart.config.options.viewArea.backgroundColor) {
-			var ctx = chart.chart.ctx;
+			let ctx = chart.chart.ctx;
 			ctx.fillStyle = chart.config.options.viewArea.backgroundColor;
 			ctx.fillRect(0, 0, chart.chart.width, chart.chart.height);
 		}

src/sql/workbench/parts/dashboard/widgets/properties/propertiesJson.ts

@@ -1,7 +1,7 @@
 /*---------------------------------------------------------------------------------------------
-*  Copyright (c) Microsoft Corporation. All rights reserved.
-*  Licensed under the Source EULA. See License.txt in the project root for license information.
-*--------------------------------------------------------------------------------------------*/
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
 
 import { ProviderProperties } from './propertiesWidget.component';
 import * as nls from 'vs/nls';