Renable Strict TSLint (#5018)

* removes more builder references

* remove builder from profiler

* formatting

* fix profiler dailog

* remove builder from oatuhdialog

* remove the rest of builder references

* formatting

* add more strict null checks to base

* enable strict tslint rules

* fix formatting

* fix compile error

* fix the rest of the hygeny issues and add pipeline step

* fix pipeline files

src/sql/workbench/parts/grid/common/interfaces.ts

@@ -1,4 +1,3 @@
-
 /*---------------------------------------------------------------------------------------------
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the Source EULA. See License.txt in the project root for license information.

src/sql/workbench/parts/grid/media/flexbox.css

@@ -1,71 +1,76 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
 .fullsize {
-    height: 100%;
-    width: 100%;
+	height: 100%;
+	width: 100%;
 }
 
 /* vertical box styles */
 .vertBox {
-    display: flex;
-    flex-flow: column;
+	display: flex;
+	flex-flow: column;
 }
 
 .vertBox .boxRow.header {
-    flex: 0 0 auto;
+	flex: 0 0 auto;
 }
 
 .vertBox .boxRow.content {
-    flex: 1 1 0;
+	flex: 1 1 0;
 }
 
 .edgesPadding {
-    padding-left: 10px;
-    padding-right: 10px;
-    padding-top: 10px;
+	padding-left: 10px;
+	padding-right: 10px;
+	padding-top: 10px;
 }
 
 .messagesTopSpacing {
-    height: 5px;
+	height: 5px;
 }
 
 .results {
-    flex: 100 1 0;
+	flex: 100 1 0;
 }
 
 .scrollable {
-    overflow: auto;
+	overflow: auto;
 }
 
 .maxHeight {
-    max-height: fit-content;
+	max-height: fit-content;
 }
 
 .minHeight {
-    min-height: fit-content;
+	min-height: fit-content;
 }
 
 /* horizontal box style */
 .horzBox {
-    display: flex;
-    flex-flow: row;
+	display: flex;
+	flex-flow: row;
 }
 
 .horzBox .boxCol.content {
-    flex: 1 1 1%;
-    overflow: auto;
-    max-width: fit-content;
+	flex: 1 1 1%;
+	overflow: auto;
+	max-width: fit-content;
 }
 
 .hidden {
-    display: none !important;
+	display: none !important;
 }
 
 /* testing
 
 .vertBox {
-    border: 1px solid green;
+	border: 1px solid green;
 }
 
 .horzBox {
-    border: 1px solid red;
+	border: 1px solid red;
 }
 */

src/sql/workbench/parts/grid/views/editData/editData.component.html

@@ -7,7 +7,7 @@
 
 <div class="fullsize vertBox editdata-component">
 	<div id="results" *ngIf="renderedDataSets.length > 0" class="results vertBox scrollable"
-		 (onScroll)="onScroll($event)" [class.hidden]="!resultActive">
+		(onScroll)="onScroll($event)" [class.hidden]="!resultActive">
 		<div class="boxRow content horzBox slickgrid editable" *ngFor="let dataSet of renderedDataSets; let i = index"
 			[style.max-height]="dataSet.maxHeight" [style.min-height]="dataSet.minHeight">
 			<slick-grid #slickgrid id="slickgrid_{{i}}" [columnDefinitions]="dataSet.columnDefinitions"

src/sql/workbench/parts/grid/views/gridParentComponent.ts

@@ -370,7 +370,7 @@ export abstract class GridParentComponent {
 	}
 
 	protected _keybindingFor(action: IAction): ResolvedKeybinding {
-		var [kb] = this.keybindingService.lookupKeybindings(action.id);
+		let [kb] = this.keybindingService.lookupKeybindings(action.id);
 		return kb;
 	}
 
@@ -407,8 +407,6 @@ export abstract class GridParentComponent {
 	/**
 	 * Returns a function that selects all elements of a grid. This needs to
 	 * return a function in order to capture the scope for this component
-	 * @private
-	 * @returns {(gridIndex: number) => void}
 	 *
 	 * @memberOf QueryComponent
 	 */
@@ -559,11 +557,6 @@ export abstract class GridParentComponent {
 	 * Called by keyEvent method to give child classes a chance to
 	 * handle key events.
 	 *
-	 * @protected
-	 * @abstract
-	 * @param {StandardKeyboardEvent} e
-	 * @returns {boolean}
-	 *
 	 * @memberOf GridParentComponent
 	 */
 	protected abstract tryHandleKeyEvent(e: StandardKeyboardEvent): boolean;