Renable Strict TSLint (#5018)

* removes more builder references

* remove builder from profiler

* formatting

* fix profiler dailog

* remove builder from oatuhdialog

* remove the rest of builder references

* formatting

* add more strict null checks to base

* enable strict tslint rules

* fix formatting

* fix compile error

* fix the rest of the hygeny issues and add pipeline step

* fix pipeline files
This commit is contained in:
Anthony Dresser
2019-04-18 00:34:53 -07:00
committed by GitHub
parent b852f032d3
commit ddd89fc52a
431 changed files with 3147 additions and 3789 deletions

View File

@@ -225,10 +225,10 @@ suite('TelemetryService', () => {
// let origErrorHandler = Errors.errorHandler.getUnexpectedErrorHandler();
// Errors.setUnexpectedErrorHandler(() => { });
// try {
// let testAppender = new TestTelemetryAppender();
// let service = new JoinableTelemetryService({ appender: testAppender }, undefined!);
// const errorTelemetry = new ErrorTelemetry(service);
// try {
// let testAppender = new TestTelemetryAppender();
// let service = new JoinableTelemetryService({ appender: testAppender }, undefined!);
// const errorTelemetry = new ErrorTelemetry(service);
// let e: any = new Error('This is a test.');
@@ -237,13 +237,13 @@ suite('TelemetryService', () => {
// e.stack = 'blah';
// }
// Errors.onUnexpectedError(e);
// this.clock.tick(ErrorTelemetry.ERROR_FLUSH_TIMEOUT);
// await service.join();
// Errors.onUnexpectedError(e);
// this.clock.tick(ErrorTelemetry.ERROR_FLUSH_TIMEOUT);
// await service.join();
// assert.equal(testAppender.getEventsCount(), 1);
// assert.equal(testAppender.events[0].eventName, 'UnhandledError');
// assert.equal(testAppender.events[0].data.msg, 'This is a test.');
// assert.equal(testAppender.getEventsCount(), 1);
// assert.equal(testAppender.events[0].eventName, 'UnhandledError');
// assert.equal(testAppender.events[0].data.msg, 'This is a test.');
// errorTelemetry.dispose();
// service.dispose();