Renable Strict TSLint (#5018)

* removes more builder references

* remove builder from profiler

* formatting

* fix profiler dailog

* remove builder from oatuhdialog

* remove the rest of builder references

* formatting

* add more strict null checks to base

* enable strict tslint rules

* fix formatting

* fix compile error

* fix the rest of the hygeny issues and add pipeline step

* fix pipeline files

src/vs/workbench/api/browser/mainThreadDebugService.ts

@@ -3,9 +3,6 @@
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-// {{SQL CARBON EDIT}}
-/*
-
 import { IDisposable, dispose } from 'vs/base/common/lifecycle';
 import { URI as uri } from 'vs/base/common/uri';
 import { IDebugService, IConfig, IDebugConfigurationProvider, IBreakpoint, IFunctionBreakpoint, IBreakpointData, ITerminalSettings, IDebugAdapter, IDebugAdapterDescriptorFactory, IDebugSession, IDebugAdapterFactory, IDebugAdapterTrackerFactory } from 'vs/workbench/contrib/debug/common/debug';
@@ -352,9 +349,6 @@ export class MainThreadDebugService implements MainThreadDebugServiceShape, IDeb
 /**
  * DebugAdapter that communicates via extension protocol with another debug adapter.
  */
-
-// {{SQL CARBON EDIT}}
-/*
 class ExtensionHostDebugAdapter extends AbstractDebugAdapter {
 
 	constructor(private readonly _ds: MainThreadDebugService, private _handle: number, private _proxy: ExtHostDebugServiceShape, private _session: IDebugSession) {
@@ -381,5 +375,3 @@ class ExtensionHostDebugAdapter extends AbstractDebugAdapter {
 		return Promise.resolve(this._proxy.$stopDASession(this._handle));
 	}
 }
-// {{SQL CARBON EDIT}}
-*/

src/vs/workbench/api/browser/mainThreadKeytar.ts

@@ -1,6 +1,6 @@
 /*---------------------------------------------------------------------------------------------
  *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
 import { extHostNamedCustomer } from 'vs/workbench/api/common/extHostCustomers';

src/vs/workbench/api/common/extHost.protocol.ts

@@ -1146,8 +1146,6 @@ export interface ISourceMultiBreakpointDto {
 	}[];
 }
 
-// {{SQL CARBON EDIT}}
-/*
 export interface IDebugSessionFullDto {
 	id: DebugSessionUUID;
 	type: string;
@@ -1174,8 +1172,6 @@ export interface ExtHostDebugServiceShape {
 	$acceptDebugSessionCustomEvent(session: IDebugSessionDto, event: any): void;
 	$acceptBreakpointsDelta(delta: IBreakpointsDeltaDto): void;
 }
-// {{SQL CARBON EDIT}}
-*/
 
 export interface DecorationRequest {
 	readonly id: number;
@@ -1237,8 +1233,7 @@ export const MainContext = {
 	MainThreadComments: createMainId<MainThreadCommentsShape>('MainThreadComments'),
 	MainThreadConfiguration: createMainId<MainThreadConfigurationShape>('MainThreadConfiguration'),
 	MainThreadConsole: createMainId<MainThreadConsoleShape>('MainThreadConsole'),
-	// {{SQL CARBON EDIT}}
-	// MainThreadDebugService: createMainId<MainThreadDebugServiceShape>('MainThreadDebugService'),
+	MainThreadDebugService: createMainId<MainThreadDebugServiceShape>('MainThreadDebugService'),
 	MainThreadDecorations: createMainId<MainThreadDecorationsShape>('MainThreadDecorations'),
 	MainThreadDiagnostics: createMainId<MainThreadDiagnosticsShape>('MainThreadDiagnostics'),
 	MainThreadDialogs: createMainId<MainThreadDiaglogsShape>('MainThreadDiaglogs'),
@@ -1273,8 +1268,7 @@ export const ExtHostContext = {
 	ExtHostCommands: createExtId<ExtHostCommandsShape>('ExtHostCommands'),
 	ExtHostConfiguration: createExtId<ExtHostConfigurationShape>('ExtHostConfiguration'),
 	ExtHostDiagnostics: createExtId<ExtHostDiagnosticsShape>('ExtHostDiagnostics'),
-	// {{SQL CARBON EDIT}}
-	// ExtHostDebugService: createExtId<ExtHostDebugServiceShape>('ExtHostDebugService'),
+	ExtHostDebugService: createExtId<ExtHostDebugServiceShape>('ExtHostDebugService'),
 	ExtHostDecorations: createExtId<ExtHostDecorationsShape>('ExtHostDecorations'),
 	ExtHostDocumentsAndEditors: createExtId<ExtHostDocumentsAndEditorsShape>('ExtHostDocumentsAndEditors'),
 	ExtHostDocuments: createExtId<ExtHostDocumentsShape>('ExtHostDocuments'),

src/vs/workbench/api/common/extHostMemento.ts

@@ -1,6 +1,6 @@
 /*---------------------------------------------------------------------------------------------
  *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
 import { IDisposable } from 'vs/base/common/lifecycle';

src/vs/workbench/api/common/extHostOutput.ts

@@ -1,6 +1,6 @@
 /*---------------------------------------------------------------------------------------------
  *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
 import { MainContext, MainThreadOutputServiceShape, IMainContext, ExtHostOutputServiceShape } from './extHost.protocol';

src/vs/workbench/api/node/extHost.api.impl.ts

@@ -142,7 +142,8 @@ export function createApiFactory(
 	}
 
 	// Check that no named customers are missing
-	const expected: ProxyIdentifier<any>[] = values(ExtHostContext);
+	// {{SQL CARBON EDIT}} filter out the services we don't expose
+	const expected: ProxyIdentifier<any>[] = values(ExtHostContext).filter(v => v !== ExtHostContext.ExtHostDebugService);
 	rpcProtocol.assertRegistered(expected);
 
 	// Other instances

src/vs/workbench/api/node/extHostDebugService.ts

@@ -3,8 +3,6 @@
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-// {{SQL CARBON EDIT}}
-/*
 import * as path from 'vs/base/common/path';
 import { Schemas } from 'vs/base/common/network';
 import { URI, UriComponents } from 'vs/base/common/uri';
@@ -672,7 +670,7 @@ export class ExtHostDebugService implements ExtHostDebugServiceShape {
 				type: 'implementation',
 				implementation: x.implementation
 			};
-		} else */ /* {{SQL CARBON EDIT}} {
+		} else */ {
 			throw new Error('convertToDto unexpected type');
 		}
 	}
@@ -1050,6 +1048,3 @@ class DirectDebugAdapter extends AbstractDebugAdapter implements IDapTransport {
 		throw new Error('Method not implemented.');
 	}
 }
-
-// {{SQL CARBON EDIT}}
-*/

src/vs/workbench/api/node/extHostRequireInterceptor.ts

@@ -1,6 +1,6 @@
 /*---------------------------------------------------------------------------------------------
  *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
 import { TernarySearchTree } from 'vs/base/common/map';

src/vs/workbench/api/node/extHostStoragePaths.ts

@@ -1,6 +1,6 @@
 /*---------------------------------------------------------------------------------------------
  *  Copyright (c) Microsoft Corporation. All rights reserved.
- *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
 import * as path from 'vs/base/common/path';